Skip to content

Commit 35a4d73

Browse files
committed
Merge pull request #474 from vdice/build-version-to-dist
feat(client Makefile): add build version to dist binary via ldflags
2 parents 2d933d7 + 6bc5c16 commit 35a4d73

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

client/Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ DEV_ENV_CMD := ${DEV_ENV_PREFIX} ${DEV_ENV_IMAGE}
1717
DIST_DIR := _dist
1818

1919
GO_FILES = $(wildcard *.go)
20+
GO_LDFLAGS = -ldflags "-s -X ${repo_path}/version.BuildVersion=${VERSION}"
2021
GO_PACKAGES = cmd controller/api controller/client $(wildcard controller/models/*) parser $(wildcard pkg/*)
2122
GO_PACKAGES_REPO_PATH = $(addprefix $(repo_path)/,$(GO_PACKAGES))
2223
GOFMT = gofmt -e -l -s
@@ -54,12 +55,13 @@ build: binary-build
5455

5556
build-all:
5657
${DEV_ENV_CMD} gox -verbose \
58+
${GO_LDFLAGS} \
5759
-os="linux darwin " \
5860
-arch="amd64 386" \
5961
-output="$(DIST_DIR)/deis-${VERSION}-{{.OS}}-{{.Arch}}" .
6062

6163
binary-build:
62-
${DEV_ENV_PREFIX} -e GOOS=${GOOS} ${DEV_ENV_IMAGE} go build -a -installsuffix cgo -ldflags "-s -X ${repo_path}/version.BuildVersion=${VERSION}" -o deis .
64+
${DEV_ENV_PREFIX} -e GOOS=${GOOS} ${DEV_ENV_IMAGE} go build -a -installsuffix cgo ${GO_LDFLAGS} -o deis .
6365

6466
dist: build-all
6567

0 commit comments

Comments
 (0)