Skip to content

Commit 31af241

Browse files
committed
Clarify 2-LGTM code approval policy.
1 parent 3ee9b76 commit 31af241

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

docs/contributing/standards.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,13 @@ Commits that fix or close an issue should include a reference like
103103
*Closes #XXX* or *Fixes #XXX* in the commit message. Doing so will
104104
automatically close the `GitHub issue`_ when the pull request is merged.
105105

106+
Merge Approval
107+
--------------
108+
Deis maintainers add "**LGTM**" (Looks Good To Me) in code
109+
review comments to indicate that a PR is acceptable. Any code change--other than
110+
a simple typo fix or one-line documentation change--requires at least two of
111+
Deis' maintainers to accept the change in this manner before it can be merged.
112+
106113
.. _Python: http://www.python.org/
107114
.. _flake8: https://pypi.python.org/pypi/flake8/
108115
.. _pep8_tool: https://pypi.python.org/pypi/pep8/

0 commit comments

Comments
 (0)