Skip to content

Commit 2e48274

Browse files
committed
fix(tests): increase component test timeouts to 20min
Most component test failures in our CI system recently have been due to the tests taking longer than the default Go testing package timeout of 10 minutes. The tests are in progress, but Go kills the process after 10 minutes and reports it as failed. The tradeoff here is that if one of the tests is actually stuck, we wait twice as long to find that out, but overall this seems like a fix for CI stability. Builder was increased to 30m since it takes much longer to pull slugbuilder.
1 parent c6df4f1 commit 2e48274

7 files changed

Lines changed: 7 additions & 7 deletions

File tree

builder/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,4 @@ test-unit:
3333
@echo no unit tests
3434

3535
test-functional:
36-
GOPATH=$(CURDIR)/../tests/_vendor:$(GOPATH) go test -v -timeout 15m ./tests/...
36+
GOPATH=$(CURDIR)/../tests/_vendor:$(GOPATH) go test -v -timeout 30m ./tests/...

cache/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,4 @@ test-unit:
3333
@echo no unit tests
3434

3535
test-functional:
36-
GOPATH=$(CURDIR)/../tests/_vendor:$(GOPATH) go test -v ./tests/...
36+
GOPATH=$(CURDIR)/../tests/_vendor:$(GOPATH) go test -v -timeout 20m ./tests/...

controller/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,4 +52,4 @@ test-unit:
5252
venv/bin/python manage.py test --noinput api
5353

5454
test-functional:
55-
GOPATH=$(CURDIR)/../tests/_vendor:$(GOPATH) go test -v ./tests/...
55+
GOPATH=$(CURDIR)/../tests/_vendor:$(GOPATH) go test -v -timeout 20m ./tests/...

database/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,4 @@ test-unit:
3333
@echo no unit tests
3434

3535
test-functional:
36-
GOPATH=$(CURDIR)/../tests/_vendor:$(GOPATH) go test -v ./tests/...
36+
GOPATH=$(CURDIR)/../tests/_vendor:$(GOPATH) go test -v -timeout 20m ./tests/...

logger/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ test-unit:
3333
go test -v -cover ./syslog
3434

3535
test-functional:
36-
GOPATH=$(CURDIR)/../tests/_vendor:$(GOPATH) go test -v ./tests/...
36+
GOPATH=$(CURDIR)/../tests/_vendor:$(GOPATH) go test -v -timeout 20m ./tests/...
3737

3838
coverage:
3939
go test -coverprofile coverage.out ./syslog

registry/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,4 @@ test-unit:
4141
../venv/bin/python -m unittest discover -s test
4242

4343
test-functional:
44-
GOPATH=$(CURDIR)/../tests/_vendor:$(GOPATH) go test -v ./tests/...
44+
GOPATH=$(CURDIR)/../tests/_vendor:$(GOPATH) go test -v -timeout 20m ./tests/...

router/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,4 @@ test-unit:
4949
@echo no unit tests
5050

5151
test-functional:
52-
GOPATH=$(CURDIR)/../tests/_vendor:$(GOPATH) go test -v ./tests/...
52+
GOPATH=$(CURDIR)/../tests/_vendor:$(GOPATH) go test -v -timeout 20m ./tests/...

0 commit comments

Comments
 (0)