refactor(builder): improve build + config = release

- add release version as header on build and config creation
- provide dynamic output on build/config CLI, including resulting release
- add `deis push` CLI shortcut for builds:create

Author: Gabriel Monroy

client/deis.py

@@ -758,6 +758,31 @@ def builds(self, args):
         """
         return self.builds_list(args)
 
+    def builds_create(self, args):
+        """
+        Create a new build of an application
+
+        Usage: deis builds:create <image> [--app=<app>]
+        """
+        app = args.get('--app')
+        if not app:
+            app = self._session.app
+        body = {'image': args['<image>']}
+        sys.stdout.write('Creating build... ')
+        sys.stdout.flush()
+        try:
+            progress = TextProgress()
+            progress.start()
+            response = self._dispatch('post', "/api/apps/{}/builds".format(app), json.dumps(body))
+        finally:
+            progress.cancel()
+            progress.join()
+        if response.status_code == requests.codes.created:  # @UndefinedVariable
+            version = response.headers['x-deis-release']
+            print("done, v{}".format(version))
+        else:
+            raise ResponseError(response)
+
     def builds_list(self, args):
         """
         List build history for an application
@@ -984,10 +1009,18 @@ def config_set(self, args):
         if not app:
             app = self._session.app
         body = {'values': json.dumps(dictify(args['<var>=<value>']))}
-        response = self._dispatch('post',
-                                  "/api/apps/{}/config".format(app),
-                                  json.dumps(body))
+        sys.stdout.write('Creating config... ')
+        sys.stdout.flush()
+        try:
+            progress = TextProgress()
+            progress.start()
+            response = self._dispatch('post', "/api/apps/{}/config".format(app), json.dumps(body))
+        finally:
+            progress.cancel()
+            progress.join()
         if response.status_code == requests.codes.created:  # @UndefinedVariable
+            version = response.headers['x-deis-release']
+            print("done, v{}\n".format(version))
             config = response.json()
             values = json.loads(config['values'])
             print("=== {}".format(app))
@@ -1013,10 +1046,18 @@ def config_unset(self, args):
         for k in args.get('<key>'):
             values[k] = None
         body = {'values': json.dumps(values)}
-        response = self._dispatch('post',
-                                  "/api/apps/{}/config".format(app),
-                                  json.dumps(body))
+        sys.stdout.write('Creating config... ')
+        sys.stdout.flush()
+        try:
+            progress = TextProgress()
+            progress.start()
+            response = self._dispatch('post', "/api/apps/{}/config".format(app), json.dumps(body))
+        finally:
+            progress.cancel()
+            progress.join()
         if response.status_code == requests.codes.created:  # @UndefinedVariable
+            version = response.headers['x-deis-release']
+            print("done, v{}\n".format(version))
             config = response.json()
             values = json.loads(config['values'])
             print("=== {}".format(app))

controller/api/tests/test_build.py

@@ -62,6 +62,7 @@ def test_build(self):
         body = {'image': 'autotest/example'}
         response = self.client.post(url, json.dumps(body), content_type='application/json')
         self.assertEqual(response.status_code, 201)
+        self.assertIn('x-deis-release', response._headers)
         build3 = response.data
         self.assertEqual(response.data['image'], body['image'])
         self.assertNotEqual(build2['uuid'], build3['uuid'])

controller/api/tests/test_config.py

@@ -51,6 +51,7 @@ def test_config(self):
         body = {'values': json.dumps({'NEW_URL1': 'http://localhost:8080/'})}
         response = self.client.post(url, json.dumps(body), content_type='application/json')
         self.assertEqual(response.status_code, 201)
+        self.assertIn('x-deis-release', response._headers)
         config2 = response.data
         self.assertNotEqual(config1['uuid'], config2['uuid'])
         self.assertIn('NEW_URL1', json.loads(response.data['values']))

controller/api/views.py

@@ -345,11 +345,16 @@ class AppBuildViewSet(BaseAppViewSet):
     model = models.Build
     serializer_class = serializers.BuildSerializer
 
-    def post_save(self, obj, created=False):
+    def post_save(self, build, created=False):
         if created:
-            release = obj.app.release_set.latest()
-            new_release = release.new(self.request.user, build=obj)
-            obj.app.deploy(new_release)
+            release = build.app.release_set.latest()
+            self.release = release.new(self.request.user, build=build)
+            build.app.deploy(self.release)
+
+    def get_success_headers(self, data):
+        headers = super(AppBuildViewSet, self).get_success_headers(data)
+        headers.update({'X-Deis-Release': self.release.version})
+        return headers
 
     def create(self, request, *args, **kwargs):
         app = get_object_or_404(models.App, id=self.kwargs['id'])
@@ -372,11 +377,16 @@ def get_object(self, *args, **kwargs):
             return app.release_set.latest().config
         raise PermissionDenied()
 
-    def post_save(self, obj, created=False):
+    def post_save(self, config, created=False):
         if created:
-            release = obj.app.release_set.latest()
-            new_release = release.new(self.request.user, config=obj)
-            obj.app.deploy(new_release)
+            release = config.app.release_set.latest()
+            self.release = release.new(self.request.user, config=config)
+            config.app.deploy(self.release)
+
+    def get_success_headers(self, data):
+        headers = super(AppConfigViewSet, self).get_success_headers(data)
+        headers.update({'X-Deis-Release': self.release.version})
+        return headers
 
     def create(self, request, *args, **kwargs):
         request._data = request.DATA.copy()