ref(*): move ADD command to bottom

This effectively lets us cache the VOLUME, WORKDIR, EXPOSE, etc.
entries whenever we make changes to the components, speeding up local
development compilation.

Author: Matthew Fisher

builder/Dockerfile

@@ -40,13 +40,12 @@ RUN echo "%git    ALL=(ALL:ALL) NOPASSWD:/home/git/builder" >> /etc/sudoers
 RUN wget -O /progrium_cedarish.tar --progress=dot:giga \
         https://s3-us-west-2.amazonaws.com/opdemand/progrium_cedarish_2014.05.27.tar
 
-# add the current build context to /app
-ADD . /app
-RUN chown -R root:root /app
-
 # define the execution environment
 VOLUME /var/lib/docker
 WORKDIR /app
 ENTRYPOINT ["/app/bin/entry"]
 CMD ["/app/bin/boot"]
 EXPOSE 22
+
+ADD . /app
+RUN chown -R root:root /app

cache/Dockerfile

@@ -6,10 +6,7 @@ RUN apt-get update && apt-get install -yq python-software-properties
 RUN add-apt-repository ppa:chris-lea/redis-server -y
 RUN apt-get update && apt-get install -yq redis-server
 
-# add the current build context to /app
-ADD . /app
-
-# define the execution environment
 WORKDIR /app
 CMD ["/app/bin/boot"]
 EXPOSE 6379
+ADD . /app

controller/Dockerfile

@@ -34,7 +34,6 @@ WORKDIR /app
 ADD requirements.txt /app/requirements.txt
 RUN pip install -r /app/requirements.txt
 
-# clone the project into /app
 ADD . /app
 
 # Create static resources

database/Dockerfile

@@ -6,11 +6,9 @@ RUN echo "deb http://apt.postgresql.org/pub/repos/apt/ precise-pgdg main" > /etc
 RUN wget --quiet --no-check-certificate -O - https://www.postgresql.org/media/keys/ACCC4CF8.asc | apt-key add -
 RUN apt-get update && apt-get install -yq postgresql-9.3 && /etc/init.d/postgresql stop
 
-# add the current build context to /app
-ADD . /app
-
 # define the execution environment
 VOLUME ["/var/lib/postgresql"]
 WORKDIR /app
 CMD ["/app/bin/boot"]
 EXPOSE 5432
+ADD . /app

logger/Dockerfile

@@ -9,17 +9,16 @@ RUN mkdir -p /go
 ENV GOPATH /go
 ENV PATH /usr/local/bin:/usr/bin:/bin:/sbin:/usr/local/go/bin
 
-# add the current build context to /app
-ADD . /app
-ADD . /go/src/github.com/deis/deis/logger
-
-# compile the binary
-RUN cd /go/src/github.com/deis/deis/logger/syslogd && go install -v .
-
 # create /var/log/deis for holding logs (access via bind mount)
 RUN mkdir -p /var/log/deis
 
 # prepare execution environment
 WORKDIR /app
 CMD ["/app/bin/boot"]
 EXPOSE 514
+
+ADD . /app
+ADD . /go/src/github.com/deis/deis/logger
+
+# compile the binary
+RUN cd /go/src/github.com/deis/deis/logger/syslogd && go install -v .

registry/Dockerfile

@@ -36,10 +36,8 @@ RUN mkdir -p /data/repositories && chown -R registry:registry /data
 ENV STORAGE_PATH /data
 VOLUME /data
 
-# add the current build context to /app
-ADD . /app
-
 # define the execution environment
 WORKDIR /app
 CMD ["/app/bin/boot"]
 EXPOSE 5000
+ADD . /app

router/Dockerfile

@@ -16,7 +16,7 @@ RUN patch -p1 < /tmp/nginx_tcp_proxy_module-0.4.5/tcp.patch
 RUN ./configure --prefix=/var/lib/nginx --sbin-path=/usr/sbin/nginx --conf-path=/etc/nginx/nginx.conf --http-log-path=/var/log/nginx/access.log --error-log-path=/var/log/nginx/error.log --lock-path=/var/lock/nginx.lock --pid-path=/run/nginx.pid --http-client-body-temp-path=/var/lib/nginx/body --http-fastcgi-temp-path=/var/lib/nginx/fastcgi --http-proxy-temp-path=/var/lib/nginx/proxy --http-scgi-temp-path=/var/lib/nginx/scgi --http-uwsgi-temp-path=/var/lib/nginx/uwsgi --with-debug --with-pcre-jit --with-ipv6 --with-http_ssl_module --with-http_stub_status_module --with-http_realip_module --with-http_auth_request_module --with-http_addition_module --with-http_dav_module --with-http_geoip_module --with-http_gzip_static_module --with-http_spdy_module --with-http_sub_module --with-mail --with-mail_ssl_module --add-module=/tmp/nginx_tcp_proxy_module-0.4.5
 RUN make && make install
 
-ADD . /app
 WORKDIR /app
 EXPOSE 80 2222
 CMD ["/app/bin/boot"]
+ADD . /app