ref(serializers): have serializers discover read-only fields from models

Author: helgi

rootfs/api/models/certificate.py

@@ -25,7 +25,7 @@ class Certificate(AuditedModel):
     key = models.TextField()
     # X.509 certificates allow any string of information as the common name.
     common_name = models.TextField(unique=True)
-    expires = models.DateTimeField()
+    expires = models.DateTimeField(editable=False)
 
     def __str__(self):
         return self.common_name

rootfs/api/models/key.py

@@ -22,7 +22,7 @@ class Key(UuidAuditedModel):
     owner = models.ForeignKey(settings.AUTH_USER_MODEL)
     id = models.CharField(max_length=128)
     public = models.TextField(unique=True, validators=[validate_base64])
-    fingerprint = models.CharField(max_length=128)
+    fingerprint = models.CharField(max_length=128, editable=False)
 
     class Meta:
         verbose_name = 'SSH Key'

rootfs/api/serializers.py

@@ -99,14 +99,11 @@ class AppSerializer(serializers.ModelSerializer):
 
     owner = serializers.ReadOnlyField(source='owner.username')
     structure = serializers.JSONField(required=False)
-    created = serializers.DateTimeField(read_only=True)
-    updated = serializers.DateTimeField(read_only=True)
 
     class Meta:
         """Metadata options for a :class:`AppSerializer`."""
         model = models.App
         fields = ['uuid', 'id', 'owner', 'structure', 'created', 'updated']
-        read_only_fields = ['uuid']
 
 
 class BuildSerializer(serializers.ModelSerializer):
@@ -115,15 +112,12 @@ class BuildSerializer(serializers.ModelSerializer):
     app = serializers.SlugRelatedField(slug_field='id', queryset=models.App.objects.all())
     owner = serializers.ReadOnlyField(source='owner.username')
     procfile = serializers.JSONField(required=False)
-    created = serializers.DateTimeField(read_only=True)
-    updated = serializers.DateTimeField(read_only=True)
 
     class Meta:
         """Metadata options for a :class:`BuildSerializer`."""
         model = models.Build
         fields = ['owner', 'app', 'image', 'sha', 'procfile', 'dockerfile', 'created',
                   'updated', 'uuid']
-        read_only_fields = ['uuid']
 
 
 class ConfigSerializer(serializers.ModelSerializer):
@@ -135,8 +129,6 @@ class ConfigSerializer(serializers.ModelSerializer):
     memory = JSONFieldSerializer(required=False, binary=True)
     cpu = JSONFieldSerializer(required=False, binary=True)
     tags = JSONFieldSerializer(required=False, binary=True)
-    created = serializers.DateTimeField(read_only=True)
-    updated = serializers.DateTimeField(read_only=True)
 
     class Meta:
         """Metadata options for a :class:`ConfigSerializer`."""
@@ -207,8 +199,6 @@ class ReleaseSerializer(serializers.ModelSerializer):
 
     app = serializers.SlugRelatedField(slug_field='id', queryset=models.App.objects.all())
     owner = serializers.ReadOnlyField(source='owner.username')
-    created = serializers.DateTimeField(read_only=True)
-    updated = serializers.DateTimeField(read_only=True)
 
     class Meta:
         """Metadata options for a :class:`ReleaseSerializer`."""
@@ -220,8 +210,6 @@ class ContainerSerializer(serializers.ModelSerializer):
 
     app = serializers.SlugRelatedField(slug_field='id', queryset=models.App.objects.all())
     owner = serializers.ReadOnlyField(source='owner.username')
-    created = serializers.DateTimeField(read_only=True)
-    updated = serializers.DateTimeField(read_only=True)
     release = serializers.SerializerMethodField()
 
     class Meta:
@@ -237,9 +225,6 @@ class KeySerializer(serializers.ModelSerializer):
     """Serialize a :class:`~api.models.Key` model."""
 
     owner = serializers.ReadOnlyField(source='owner.username')
-    fingerprint = serializers.CharField(read_only=True)
-    created = serializers.DateTimeField(read_only=True)
-    updated = serializers.DateTimeField(read_only=True)
 
     class Meta:
         """Metadata options for a KeySerializer."""
@@ -251,8 +236,6 @@ class DomainSerializer(serializers.ModelSerializer):
 
     app = serializers.SlugRelatedField(slug_field='id', queryset=models.App.objects.all())
     owner = serializers.ReadOnlyField(source='owner.username')
-    created = serializers.DateTimeField(read_only=True)
-    updated = serializers.DateTimeField(read_only=True)
 
     class Meta:
         """Metadata options for a :class:`DomainSerializer`."""
@@ -295,26 +278,20 @@ class CertificateSerializer(serializers.ModelSerializer):
     """Serialize a :class:`~api.models.Cert` model."""
 
     owner = serializers.ReadOnlyField(source='owner.username')
-    expires = serializers.DateTimeField(read_only=True)
-    created = serializers.DateTimeField(read_only=True)
-    updated = serializers.DateTimeField(read_only=True)
 
     class Meta:
         """Metadata options for a DomainCertSerializer."""
         model = models.Certificate
         extra_kwargs = {'certificate': {'write_only': True},
                         'key': {'write_only': True},
                         'common_name': {'required': False}}
-        read_only_fields = ['expires', 'created', 'updated']
 
 
 class PushSerializer(serializers.ModelSerializer):
     """Serialize a :class:`~api.models.Push` model."""
 
     app = serializers.SlugRelatedField(slug_field='id', queryset=models.App.objects.all())
     owner = serializers.ReadOnlyField(source='owner.username')
-    created = serializers.DateTimeField(read_only=True)
-    updated = serializers.DateTimeField(read_only=True)
 
     class Meta:
         """Metadata options for a :class:`PushSerializer`."""