ref(controller): switch back to bash

Author: Matthew Fisher

controller/api/models.py

@@ -406,7 +406,7 @@ def _get_command(self):
             return ''
         try:
             # ensure they cannot break out and run commands on the host
-            return "env '{}'".format(self.release.build.procfile[self.type])
+            return "bash -c '{}'".format(self.release.build.procfile[self.type])
         # if the key is not present or if a parent attribute is None
         except (KeyError, TypeError):
             return 'start {}'.format(self.type)

controller/api/tests/test_container.py

@@ -461,9 +461,9 @@ def test_command_good(self):
                                      release=release,
                                      type='web',
                                      num=1)
-        self.assertEqual(c._command, "env 'node server.js'")
+        self.assertEqual(c._command, "bash -c 'node server.js'")
         c.type = 'worker'
-        self.assertEqual(c._command, "env 'node worker.js'")
+        self.assertEqual(c._command, "bash -c 'node worker.js'")
         c.release.build.procfile = None
         self.assertEqual(c._command, 'start worker')
         c.type = 'cmd'