fix(Makefile): use fleetctl to filter actual deis-* units

Call `fleetctl` to see which deis-* units are actually loaded, and then
reference only those in the `make stop` and `make uninstall` commands.
This avoids requiring special logic for router(s) except on start.
Requires `awk`, `sed`, and `tr` utilities, which should be ubiquitous.

This also is future-proofing for `fleetctl` 3.x, which returns errors in
many cases where version 2.0 allowed us to be sloppy. Thus the `deis_units`
def is written to accept filters on columns 2 (LOAD) and 4 (SUB) of the
fleetctl output. We will make more use of this when moving to CoreOS 317.0.0.

Closes #991.

Author: mboersma

Makefile

@@ -42,6 +42,12 @@ define check_for_errors
 	fi
 endef
 
+define deis_units
+	$(shell $(FLEETCTL) list-units -no-legend=true | \
+	  awk '($$2 ~ "$(1)" && ($$4 ~ "$(2)"))' | \
+	  sed -n 's/\(deis-.*\.service\).*/\1/p' | tr '\n' ' ')
+endef
+
 define echo_yellow
 	@echo "\033[0;33m$(subst ",,$(1))\033[0m"
 endef
@@ -110,21 +116,21 @@ start: check-fleet start-routers
 
 start-routers:
 	$(call echo_yellow,"Starting $(DEIS_NUM_ROUTERS) router(s)...")
-	@ $(foreach C, $(ROUTER_UNITS), \
-		cp router/systemd/deis-router.service ./$(C).service ; \
-		fleetctl --strict-host-key-checking=false submit ./$(C).service ; \
-		fleetctl --strict-host-key-checking=false start ./$(C).service ; \
-		rm -f ./$(C).service ; \
+	@ $(foreach U, $(ROUTER_UNITS), \
+		cp router/systemd/deis-router.service ./$(U) ; \
+		$(FLEETCTL) submit ./$(U) ; \
+		$(FLEETCTL) start ./$(U) ; \
+		rm -f ./$(U) ; \
 	)
 
 status: check-fleet
 	$(FLEETCTL) list-units
 
 stop: check-fleet
-	$(FLEETCTL) stop $(ALL_UNITS)
+	$(FLEETCTL) stop $(call deis_units,loaded,.)
 
 tests:
 	cd test && bundle install && bundle exec rake
 
 uninstall: check-fleet stop
-	$(FLEETCTL) destroy $(ALL_UNITS)
+	$(FLEETCTL) destroy $(call deis_units,loaded,.)