Skip to content

Commit 15751ad

Browse files
author
Matthew Fisher
committed
fix(builder): do not check for a Procfile
Some applications do not have a Procfile present before a buildpack compile step[1]. If a Dockerfile is not present, then the builder should make the assumption that this app is a buildpack app. [1]: https://github.com/bacongobbler/heroku-buildpack-jekyll/blob/master/bin/release
1 parent b45dc22 commit 15751ad

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

builder/templates/builder

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,9 @@ if __name__ == '__main__':
5555
rc = p.wait()
5656
if rc != 0:
5757
raise Exception('Could not extract git archive')
58-
# check for Procfile
5958
dockerfile = os.path.join(temp_dir, 'Dockerfile')
60-
procfile = os.path.join(temp_dir, 'Procfile')
61-
if not os.path.exists(dockerfile) and os.path.exists(procfile):
59+
# some applications do not have a Procfile, so only check for a Dockerfile
60+
if not os.path.exists(dockerfile):
6261
if os.path.exists('/buildpacks'):
6362
build_cmd = "docker run -i -a stdin -v {cache_dir}:/tmp/cache:rw -v /buildpacks:/tmp/buildpacks deis/slugbuilder".format(**locals())
6463
else:

0 commit comments

Comments
 (0)