feat(*): build test-etcd, test-postgresql, and mock-store locally

carmstrong · carmstrong · commit 14e00ef6dab2 · 2015-07-29T15:49:11.000-07:00
Previously we were relying on someone manually building and pushing
these to Docker Hub. We should build these with our BUILD_TAG like
we do all components, so that Jenkins can pick up local changes
in a branch.
diff --git a/builder/Makefile b/builder/Makefile
@@ -67,7 +67,7 @@ test-unit:
 	$(GOTEST) .
 
 test-functional:
-	@docker history deis/test-etcd >/dev/null 2>&1 || docker pull deis/test-etcd:latest
+	@$(MAKE) -C ../tests/ test-etcd
 	godep go test -v ./tests/...
 
 test-style:
diff --git a/cache/Makefile b/cache/Makefile
@@ -67,5 +67,5 @@ test-style:
 	$(GOLINT) ./...
 
 test-functional:
-	@docker history deis/test-etcd >/dev/null 2>&1 || docker pull deis/test-etcd:latest
+	@$(MAKE) -C ../tests/ test-etcd
 	GOPATH=`cd ../tests/ && godep path`:$(GOPATH) go test -v ./tests/...
diff --git a/controller/Makefile b/controller/Makefile
@@ -79,6 +79,6 @@ test-unit: setup-venv test-style
 	venv/bin/coverage report -m
 
 test-functional:
-	@docker history deis/test-etcd >/dev/null 2>&1 || docker pull deis/test-etcd:latest
-	@docker history deis/test-postgresql >/dev/null 2>&1 || docker pull deis/test-postgresql:latest
+	@$(MAKE) -C ../tests/ test-etcd
+	@$(MAKE) -C ../tests/ test-postgresql
 	GOPATH=`cd ../tests/ && godep path`:$(GOPATH) go test -v ./tests/...
diff --git a/database/Makefile b/database/Makefile
@@ -54,6 +54,6 @@ test-style:
 	shellcheck $(SHELL_SCRIPTS)
 
 test-functional:
-	@docker history deis/mock-store >/dev/null 2>&1 || $(MAKE) -C ../tests/ mock-store
-	@docker history deis/test-etcd >/dev/null 2>&1 || docker pull deis/test-etcd:latest
+	@$(MAKE) -C ../tests/ mock-store
+	@$(MAKE) -C ../tests/ test-etcd
 	GOPATH=`cd ../tests/ && godep path`:$(GOPATH) go test -v ./tests/...
diff --git a/docs/contributing/testing.rst b/docs/contributing/testing.rst
@@ -60,10 +60,7 @@ continuous deployment, start one locally:
 
     The functional tests also use several mock or example containers:
     **deis/test-etcd**, **deis/test-postgresql**, and **deis/mock-store**.
-    These are referenced by the ``:latest`` tag, so in the rare case that one
-    of these test containers needs to change, ``docker rmi`` its image and
-    the tests will pull it from Docker Hub or rebuild it.
-
+    These are built locally during a test run.
 
 Run the Tests
 -------------
diff --git a/logger/Makefile b/logger/Makefile
@@ -58,7 +58,7 @@ deploy: build dev-release restart
 test: test-style test-unit test-functional
 
 test-functional:
-	@docker history deis/test-etcd >/dev/null 2>&1 || docker pull deis/test-etcd:latest
+	@$(MAKE) -C ../tests/ test-etcd
 	GOPATH=`cd ../tests/ && godep path`:$(GOPATH) go test -v ./tests/...
 
 test-style:
diff --git a/registry/Makefile b/registry/Makefile
@@ -46,8 +46,8 @@ deploy: build dev-release restart
 test: test-style test-unit test-functional
 
 test-functional:
-	@docker history deis/mock-store >/dev/null 2>&1 || $(MAKE) -C ../tests/ mock-store
-	@docker history deis/test-etcd >/dev/null 2>&1 || docker pull deis/test-etcd:latest
+	@$(MAKE) -C ../tests/ mock-store
+	@$(MAKE) -C ../tests/ test-etcd
 	GOPATH=`cd ../tests/ && godep path`:$(GOPATH) go test -v ./tests/...
 
 test-style:
diff --git a/router/Makefile b/router/Makefile
@@ -63,7 +63,7 @@ deploy: build dev-release restart
 test: test-style test-unit test-functional
 
 test-functional:
-	@docker history deis/test-etcd >/dev/null 2>&1 || docker pull deis/test-etcd:latest
+	@$(MAKE) -C ../tests/ test-etcd
 	GOPATH=`cd ../tests/ && godep path`:$(GOPATH) go test -v ./tests/...
 
 test-style:
diff --git a/store/Makefile b/store/Makefile
@@ -100,7 +100,7 @@ deploy: build dev-release restart
 test: test-style test-unit test-functional
 
 test-functional:
-	@docker history deis/test-etcd >/dev/null 2>&1 || docker pull deis/test-etcd:latest
+	@$(MAKE) -C ../tests/ test-etcd
 	GOPATH=`cd ../tests/ && godep path`:$(GOPATH) go test -v ./tests/...
 
 test-style:
diff --git a/tests/Makefile b/tests/Makefile
@@ -7,9 +7,9 @@ GO_FILES = $(wildcard *.go)
 GO_PACKAGES = dockercli etcdutils mock utils
 GO_PACKAGES_REPO_PATH = $(addprefix $(repo_path)/,$(GO_PACKAGES))
 
-MOCK_STORE_IMAGE = $(IMAGE_PREFIX)mock-store:latest
-TEST_ETCD_IMAGE = $(IMAGE_PREFIX)test-etcd:latest
-TEST_POSTGRESQL_IMAGE = $(IMAGE_PREFIX)test-postgresql:latest
+MOCK_STORE_IMAGE = $(IMAGE_PREFIX)mock-store:$(BUILD_TAG)
+TEST_ETCD_IMAGE = $(IMAGE_PREFIX)test-etcd:$(BUILD_TAG)
+TEST_POSTGRESQL_IMAGE = $(IMAGE_PREFIX)test-postgresql:$(BUILD_TAG)
 
 test: test-smoke
 
diff --git a/tests/bin/prime-docker-images.sh b/tests/bin/prime-docker-images.sh
@@ -12,5 +12,3 @@ docker rmi -f `docker images -q`
 
 # Pull Deis testing essentials
 docker pull alpine:3.1
-docker pull deis/test-etcd:latest
-docker pull deis/test-postgresql:latest
diff --git a/tests/dockercli/dockercli.go b/tests/dockercli/dockercli.go
@@ -266,10 +266,10 @@ func GetImageID(t *testing.T, repo string) string {
 func RunTestEtcd(t *testing.T, name string, port string) {
 	var err error
 	cli, stdout, stdoutPipe := NewClient()
-	etcdImage := "deis/test-etcd:latest"
+	etcdImage := utils.ImagePrefix() + "test-etcd:" + utils.BuildTag()
 	ipaddr := utils.HostAddress()
 	etcdAddr := ipaddr + ":" + port
-	fmt.Printf("--- Running deis/test-etcd at %s\n", etcdAddr)
+	fmt.Printf("--- Running %s at %s\n", etcdImage, etcdAddr)
 	done2 := make(chan bool, 1)
 	go func() {
 		done2 <- true
diff --git a/tests/mock/mock.go b/tests/mock/mock.go
@@ -18,7 +18,7 @@ func RunMockDatabase(t *testing.T, tag string, etcdPort string, dbPort string) {
 	var err error
 	cli, stdout, stdoutPipe := dockercli.NewClient()
 	done := make(chan bool, 1)
-	dbImage := "deis/test-postgresql:latest"
+	dbImage := utils.ImagePrefix() + "test-postgresql:" + utils.BuildTag()
 	ipaddr := utils.HostAddress()
 	done <- true
 	go func() {
@@ -53,7 +53,7 @@ func RunMockDatabase(t *testing.T, tag string, etcdPort string, dbPort string) {
 // RunMockCeph runs a container used to mock a Ceph storage cluster
 func RunMockCeph(t *testing.T, name string, cli *client.DockerCli, etcdPort string) {
 
-	storeImage := utils.ImagePrefix() + "mock-store:latest"
+	storeImage := utils.ImagePrefix() + "mock-store:" + utils.BuildTag()
 	etcdutils.SetSingle(t, "/deis/store/hosts/"+utils.HostAddress(), utils.HostAddress(), etcdPort)
 	var err error
 	cli, stdout, stdoutPipe := dockercli.NewClient()
