fix(controller): change api logs response to 204 when no logs

The controller previously responded with a 404 (Not Found) when there
were no logs available, it now returns a 204 (No Content).

closes #990

Author: Evan Cordell

controller/api/tests/test_app.py

@@ -79,7 +79,7 @@ def test_app_actions(self):
             os.remove(path)
         url = '/api/apps/{app_id}/logs'.format(**locals())
         response = self.client.post(url)
-        self.assertEqual(response.status_code, 404)
+        self.assertEqual(response.status_code, 204)
         self.assertEqual(response.data, 'No logs for {}'.format(app_id))
         # write out some fake log data and try again
         with open(path, 'w') as f:

controller/api/views.py

@@ -299,7 +299,7 @@ def logs(self, request, **kwargs):
             logs = app.logs()
         except EnvironmentError:
             return Response("No logs for {}".format(app.id),
-                            status=status.HTTP_404_NOT_FOUND,
+                            status=status.HTTP_204_NO_CONTENT,
                             content_type='text/plain')
         return Response(logs, status=status.HTTP_200_OK,
                         content_type='text/plain')