Skip to content

Commit 1210376

Browse files
committed
Merge pull request #260 from helgi/fix_secrets
fix(scheduler): python 3 b64 needs bytes but k8s api needs string passed
2 parents e93e5ab + a22dd6a commit 1210376

1 file changed

Lines changed: 8 additions & 9 deletions

File tree

rootfs/scheduler/__init__.py

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -720,19 +720,18 @@ def _healthcheck(self, controller, path='/', port=8080, delay=30, timeout=1):
720720
# SECRETS #
721721

722722
def _create_secret(self, namespace):
723-
secretId, secretKey = '', ''
724-
with open("/var/run/secrets/deis/minio/user/access-key-id") as the_file:
723+
with open("/var/run/secrets/deis/minio/user/access-key-id", "rb") as the_file:
725724
secretId = the_file.read()
726-
with open("/var/run/secrets/deis/minio/user/access-secret-key") as the_file:
725+
with open("/var/run/secrets/deis/minio/user/access-secret-key", "rb") as the_file:
727726
secretKey = the_file.read()
728-
Key, Id = base64.b64encode(secretKey), base64.b64encode(secretId)
729-
l = {
727+
728+
template = json.loads(string.Template(SECRET_TEMPLATE).substitute({
730729
"version": self.apiversion,
731730
"id": namespace,
732-
"secretId": Id,
733-
"secretKey": Key,
734-
}
735-
template = json.loads(string.Template(SECRET_TEMPLATE).substitute(l))
731+
"secretId": str(base64.b64encode(secretId)),
732+
"secretKey": str(base64.b64encode(secretKey)),
733+
}))
734+
736735
url = self._api("/namespaces/{}/secrets", namespace)
737736
resp = self.session.post(url, json=template)
738737
if unhealthy(resp.status_code):

0 commit comments

Comments
 (0)