Merge pull request #3215 from aledbf/check_static_binaries

feat(makefile): check that generated go binaries are statically linked

Author: mboersma

builder/Makefile

@@ -16,6 +16,7 @@ BINARY_DEST_DIR := image/bin
 build: check-docker
 	for i in $(BINARIES); do \
 		GOOS=linux GOARCH=amd64 CGO_ENABLED=0 godep go build -a -installsuffix cgo -v -ldflags '-s' -o $(BINARY_DEST_DIR)/$$i bin/$$i.go || exit 1; \
+		$(call check-static-binary,$(BINARY_DEST_DIR)/$$i) \
 	done
 	docker build -t $(IMAGE) image
 

cache/Makefile

@@ -14,6 +14,7 @@ BINARY_DEST_DIR = image/bin
 
 build: check-docker
 	GOOS=linux GOARCH=amd64 CGO_ENABLED=0 godep go build -a -installsuffix cgo -v -ldflags '-s' -o $(BINARY_DEST_DIR)/boot main.go || exit 1
+	$(call check-static-binary,$(BINARY_DEST_DIR)/boot)
 	docker build -t $(BUILD_IMAGE) .
 	docker cp `docker run -d $(BUILD_IMAGE)`:/usr/local/bin/redis-server $(BINARY_DEST_DIR)/
 	docker build -t $(IMAGE) image

includes.mk

@@ -48,3 +48,13 @@ check-deisctl:
 	@if [ -z $$(which deisctl) ]; then \
 	  echo "Missing \`deisctl\` utility, please install from https://github.com/deis/deis"; \
 	fi
+
+define check-static-binary
+  if file $(1) | grep -q "statically linked"; then \
+    echo -n ""; \
+  else \
+    echo "The binary file $(1) is not statically linked. Build canceled"; \
+    exit 1; \
+  fi
+endef
+

logger/Makefile

@@ -15,6 +15,7 @@ BINARY_DEST_DIR = image/bin
 
 build: check-docker
 	GOOS=linux GOARCH=amd64 CGO_ENABLED=0 godep go build -a -installsuffix cgo -v -ldflags '-s' -o $(BINARY_DEST_DIR)/logger github.com/deis/deis/logger || exit 1
+	$(call check-static-binary,$(BINARY_DEST_DIR)/logger)
 	docker build -t $(IMAGE) image
 
 clean: check-docker check-registry

logspout/Makefile

@@ -14,6 +14,7 @@ DEV_DOCKER_IMAGE := $(DEV_REGISTRY)/$(RELEASE_IMAGE)
 
 build: check-docker
 	GOOS=linux GOARCH=amd64 CGO_ENABLED=0 godep go build -a -installsuffix cgo -v -ldflags '-s' -o image/logspout
+	$(call check-static-binary,image/logspout)
 	docker build -t $(RELEASE_IMAGE) image
 
 clean:

publisher/Makefile

@@ -15,6 +15,7 @@ BINARY_DEST_DIR = image/bin
 
 build: check-docker
 	GOOS=linux GOARCH=amd64 CGO_ENABLED=0 godep go build -a -installsuffix cgo -v -ldflags '-s' -o $(BINARY_DEST_DIR)/publisher github.com/deis/deis/publisher || exit 1
+	$(call check-static-binary,$(BINARY_DEST_DIR)/publisher)
 	docker build -t $(RELEASE_IMAGE) image
 
 clean: check-docker check-registry

router/Makefile

@@ -17,6 +17,7 @@ build: check-docker
 	docker build -t $(BUILD_IMAGE) .
 	docker cp `docker run -d $(BUILD_IMAGE)`:/nginx.tgz image/
 	docker cp `docker run -d $(BUILD_IMAGE)`:/go/bin/boot image/bin/
+	$(call check-static-binary,image/bin/boot)
 	docker build -t $(IMAGE) image
 	rm image/nginx.tgz
 	rm image/bin/boot