ref(Makefiles): install tools only from root

Instead of having several similar targets, this consolidates
the installation of important go tools into the root Makefile.

Author: mboersma

Makefile

@@ -73,6 +73,18 @@ release: check-registry
 
 deploy: build dev-release restart
 
+setup-gotools:
+	go get -u -v github.com/tools/godep
+	go get -u -v github.com/golang/lint/golint
+	go get -u -v golang.org/x/tools/cmd/cover
+	go get -u -v golang.org/x/tools/cmd/vet
+
+setup-root-gotools:
+# "go vet" and "go cover" must be installed as root on some systems
+	sudo GOPATH=/tmp/tmpGOPATH go get -u -v golang.org/x/tools/cmd/cover
+	sudo GOPATH=/tmp/tmpGOPATH go get -u -v golang.org/x/tools/cmd/vet
+	sudo rm -rf /tmp/tmpGOPATH
+
 test: test-style test-unit test-functional push test-integration
 
 test-functional:

contrib/bumpver/Makefile

@@ -7,17 +7,6 @@ upx:
 clean:
 	rm -f bumpver
 
-setup-gotools-sudo:
-	sudo GOPATH=/tmp/tmpGOPATH go get -u -v golang.org/x/tools/cmd/cover
-	sudo GOPATH=/tmp/tmpGOPATH go get -u -v golang.org/x/tools/cmd/vet
-	sudo rm -rf /tmp/tmpGOPATH
-	@echo 'Please ensure that $$GOPATH/bin is in your $$PATH.'
-
-setup-gotools:
-	go get github.com/tools/godep
-	go get github.com/golang/lint/golint
-	@echo 'Please ensure that $$GOPATH/bin is in your $$PATH.'
-
 test-style:
 	go vet -x ./...
 	-golint .

deisctl/Makefile

@@ -31,16 +31,6 @@ installer:
 install:
 	godep go install -v .
 
-setup-root-gotools:
-	sudo GOPATH=/tmp/tmpGOPATH go get -u -v golang.org/x/tools/cmd/cover
-	sudo GOPATH=/tmp/tmpGOPATH go get -u -v golang.org/x/tools/cmd/vet
-	sudo rm -rf /tmp/tmpGOPATH
-
-setup-gotools:
-	go get -u github.com/golang/lint/golint
-	go get -u golang.org/x/tools/cmd/cover
-	go get -u golang.org/x/tools/cmd/vet
-
 test: test-style test-unit
 
 test-style:

logger/Makefile

@@ -55,14 +55,6 @@ release:
 
 deploy: build dev-release restart
 
-setup-root-gotools:
-	sudo GOPATH=/tmp/tmpGOPATH go get -u -v golang.org/x/tools/cmd/cover
-	sudo GOPATH=/tmp/tmpGOPATH go get -u -v golang.org/x/tools/cmd/vet
-	sudo rm -rf /tmp/tmpGOPATH
-
-setup-gotools:
-	go get -v github.com/golang/lint/golint
-
 test: test-style test-unit test-functional
 
 test-functional:

logspout/Makefile

@@ -55,14 +55,6 @@ release:
 
 deploy: build dev-release restart
 
-setup-root-gotools:
-	sudo GOPATH=/tmp/tmpGOPATH go get -u -v golang.org/x/tools/cmd/cover
-	sudo GOPATH=/tmp/tmpGOPATH go get -u -v golang.org/x/tools/cmd/vet
-	sudo rm -rf /tmp/tmpGOPATH
-
-setup-gotools:
-	go get -v github.com/golang/lint/golint
-
 test: test-style test-unit test-functional
 
 test-functional:

tests/Makefile

@@ -29,14 +29,6 @@ test-full: test-style
 	godep go test -tags integration -v -run TestReleases
 	godep go test -tags integration -v -run TestUsers
 
-setup-root-gotools:
-	sudo GOPATH=/tmp/tmpGOPATH go get -u -v golang.org/x/tools/cmd/cover
-	sudo GOPATH=/tmp/tmpGOPATH go get -u -v golang.org/x/tools/cmd/vet
-	sudo rm -rf /tmp/tmpGOPATH
-
-setup-gotools:
-	go get -v github.com/golang/lint/golint
-
 mock-store:
 	docker build -t $(MOCK_STORE_IMAGE) fixtures/mock-store/