fix(perms): print perm message

Author: duanhongyi

cmd/perms.go

@@ -49,9 +49,11 @@ func (d *DryccCmd) PermCreate(codename, uniqueid, username string) error {
 	if err != nil {
 		return err
 	}
-	d.Printf("Adding %s to %s:%s collaborators... ", username, codename, uniqueid)
+	d.Printf("Adding user %s as a collaborator for %s %s... ", username, codename, uniqueid)
+	quit := progress(d.WOut)
 	err = perms.Create(s.Client, codename, uniqueid, username)
-
+	quit <- true
+	<-quit
 	if d.checkAPICompatibility(s.Client, err) != nil {
 		return err
 	}
@@ -67,9 +69,11 @@ func (d *DryccCmd) PermDelete(userPermID uint64) error {
 	if err != nil {
 		return err
 	}
-	d.Printf("Removing user perm with id %d... ", userPermID)
+	d.Printf("Removing user permission... ")
+	quit := progress(d.WOut)
 	err = perms.Delete(s.Client, fmt.Sprintf("%d", userPermID))
-
+	quit <- true
+	<-quit
 	if d.checkAPICompatibility(s.Client, err) != nil {
 		return err
 	}

cmd/perms_test.go

@@ -133,7 +133,7 @@ func TestCreateUserPerm(t *testing.T) {
 	assert.NoError(t, err)
 	assert.Equal(t,
 		testutil.StripProgress(b.String()),
-		"Adding test-user to use_app:lorem-ipsum collaborators... done\n", "output")
+		"Adding user test-user as a collaborator for use_app lorem-ipsum... done\n", "output")
 }
 
 func TestDeleteUserPerm(t *testing.T) {
@@ -168,5 +168,5 @@ func TestDeleteUserPerm(t *testing.T) {
 	assert.NoError(t, err)
 	assert.Equal(t,
 		testutil.StripProgress(b.String()),
-		"Removing user perm with id 1... done\n", "output")
+		"Removing user permission... done\n", "output")
 }

cmd/update.go

@@ -14,15 +14,13 @@ import (
 const WorkflowCliURL = "https://www.drycc.cc/workflow-cli.txt"
 
 func (d *DryccCmd) latestVersion() (string, string, error) {
-	d.Print("Get the latest version of workflow cli... ")
 	quit := progress(d.WOut)
 	resp, err := http.Get(WorkflowCliURL)
 	quit <- true
 	<-quit
 	if err != nil {
 		return "", "", err
 	}
-	d.Println("done")
 
 	defer resp.Body.Close()
 	body, err := io.ReadAll(resp.Body)
@@ -34,8 +32,7 @@ func (d *DryccCmd) latestVersion() (string, string, error) {
 	for _, url := range strings.Split(string(body), "\n") {
 		if strings.HasSuffix(url, suffix) {
 			names := strings.Split(url, "/")
-			name := names[len(names)-1]
-			version := strings.ReplaceAll(strings.ReplaceAll(name, suffix, ""), prefix, "")
+			version := strings.ReplaceAll(strings.ReplaceAll(names[len(names)-1], suffix, ""), prefix, "")
 			return version, url, nil
 		}
 	}

drycc.go

@@ -42,7 +42,6 @@ Options:
 
 Auth commands, use 'drycc help auth' to learn more:
 
-  register      register a new user with a controller
   login         login to a controller
   logout        logout from the current controller
 

parser/perms.go

@@ -12,10 +12,10 @@ func Perms(argv []string, cmdr cmd.Commander) error {
 	usage := `
 Valid commands for perms:
 
-perms:codes           list all policy codenames
-perms:list            list all user permission for objects
-perms:create          create a user permission for objects
-perms:delete          delete a user permission for objects
+perms:codes           list all policy codename
+perms:list            list all user permission
+perms:create          create a user permission
+perms:delete          delete a user permission
 
 Use 'drycc help perms:[command]' to learn more.
 `
@@ -46,7 +46,7 @@ Use 'drycc help perms:[command]' to learn more.
 
 func permsCodes(argv []string, cmdr cmd.Commander) error {
 	usage := `
-List all object policy codenames.
+List all policy codename.
 
 Usage: drycc perms:codes [options]
 
@@ -72,7 +72,7 @@ Options:
 
 func permsList(argv []string, cmdr cmd.Commander) error {
 	usage := `
-List all user permission for objects
+List all user permission.
 
 Usage: drycc perms:list [options]
 
@@ -101,7 +101,7 @@ Options:
 
 func permCreate(argv []string, cmdr cmd.Commander) error {
 	usage := `
-Gives another user permission to use an object.
+Create a user permission.
 
 Usage: drycc perms:create <username> <codename> <uniqueid>
 
@@ -129,7 +129,7 @@ Arguments:
 
 func permDelete(argv []string, cmdr cmd.Commander) error {
 	usage := `
-Revokes another user's permission to use an object.
+Delete a user permission.
 
 Usage: drycc perms:delete <id>