Skip to content
This repository was archived by the owner on May 27, 2019. It is now read-only.

Commit 1769d2d

Browse files
committed
fix(model): Improve regex for SSL ciphers
1 parent 11e2f42 commit 1769d2d

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

model/model.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ func newCertificate(cert string, key string) *Certificate {
151151
type SSLConfig struct {
152152
Enforce bool `key:"enforce" constraint:"(?i)^(true|false)$"`
153153
Protocols string `key:"protocols" constraint:"^((SSLv2|SSLv3|TLSv1|TLSv1\\.1|TLSv1\\.2)\\s*)+$"`
154-
Ciphers string `key:"ciphers" constraint:"^([A-Z][A-Z\\d-]+:?)*$"`
154+
Ciphers string `key:"ciphers" constraint:"^(!?[A-Z][A-Z\\d\\+-]+:?)*$"`
155155
SessionCache string `key:"sessionCache" constraint:"^(off|none|((builtin(:[1-9]\\d*)?|shared:\\w+:[1-9]\\d*[kKmM]?)\\s*){1,2})$"`
156156
SessionTimeout string `key:"sessionTimeout" constraint:"^[1-9]\\d*(ms|[smhdwMy])?$"`
157157
UseSessionTickets bool `key:"useSessionTickets" constraint:"(?i)^(true|false)$"`

model/model_validation_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ func TestInvalidSSLCiphers(t *testing.T) {
260260
}
261261

262262
func TestValidSSLCiphers(t *testing.T) {
263-
testValidValues(t, newTestSSLConfig, "Ciphers", "ciphers", []string{"DHE-RSA-AES256-SHA", "DHE-RSA-AES256-SHA:DHE-DSS-AES256-SHA:AES256-SHA"})
263+
testValidValues(t, newTestSSLConfig, "Ciphers", "ciphers", []string{"DHE-RSA-AES256-SHA", "DHE-RSA-AES256-SHA:DHE-DSS-AES256-SHA:AES256-SHA", "EECDH+AES128:RSA+AES128:EECDH+AES256:RSA+AES256:EECDH+3DES:RSA+3DES:!MD5"})
264264
}
265265

266266
func TestInvalidSSLSessionCache(t *testing.T) {

0 commit comments

Comments
 (0)