feat(Makefile): add test target

as well as adding missing includes.mk

ref jenkins-jobs#343

Author: Vaughn Dice

Makefile

@@ -1,11 +1,15 @@
 SHELL = /bin/bash
+include includes.mk
 
 DOCKER_HOST = $(shell echo $$DOCKER_HOST)
 BUILD_TAG ?= git-$(shell git rev-parse --short HEAD)
 SHORT_NAME ?= nsq
 DEIS_REGISTRY ?= ${DEV_REGISTRY}
 IMAGE_PREFIX ?= deis
 
+TEST_ENV_PREFIX := docker run --rm -v ${CURDIR}:/bash -w /bash quay.io/deis/shell-dev
+SHELL_SCRIPTS = $(wildcard rootfs/opt/nsq/bin/*)
+
 include versioning.mk
 
 build: docker-build
@@ -21,6 +25,11 @@ docker-build:
 clean: check-docker
 	docker rmi $(IMAGE)
 
+test: test-style
+
+test-style: check-docker
+	${TEST_ENV_PREFIX} shellcheck $(SHELL_SCRIPTS)
+
 update-manifests:
 	sed 's#\(image:\) .*#\1 $(IMAGE)#' manifests/deis-nsqd-rc.yaml > manifests/deis-nsqd-rc.tmp.yaml
 
@@ -35,3 +44,6 @@ kube-delete:
 kube-update: update-manifests
 	kubectl delete -f manifests/deis-nsqd-rc.tmp.yaml
 	kubectl create -f manifests/deis-nsqd-rc.tmp.yaml
+
+.PHONY: build push install uninstall upgrade docker-build clean test test-style \
+	update-manifests kube-install kube-delete kube-update

includes.mk

@@ -0,0 +1,13 @@
+SHELL := /bin/bash
+
+check-docker:
+	@if [ -z $$(which docker) ]; then \
+		echo "Missing \`docker\` client which is required for development"; \
+		exit 2; \
+	fi
+
+check-kubectl:
+	@if [ -z $$(which kubectl) ]; then \
+		echo "Missing \`kubectl\` client which is required for development"; \
+		exit 2; \
+	fi

rootfs/opt/nsq/bin/start-nsqd

@@ -3,4 +3,4 @@ set -eo pipefail
 
 export MAX_READY_COUNT=${MAX_READY_COUNT:-10000}
 export DATA_PATH=${DATA_PATH:-/opt/nsq/data}
-exec nsqd -max-rdy-count ${MAX_READY_COUNT} --data-path ${DATA_PATH}
+exec nsqd -max-rdy-count "${MAX_READY_COUNT}" --data-path "${DATA_PATH}"