Skip to content

Commit 6ae5779

Browse files
committed
fix(Dockerfile): download minio from a mirror (#110)
The mirror is in Google Cloud Storage. Also adds detail in the README about where the mirror is and how to upgrade binaries in it. Fixes deis/minio#108
1 parent 6ed341f commit 6ae5779

3 files changed

Lines changed: 8 additions & 2 deletions

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,4 @@ docker-build: build
4444

4545
deploy: build docker-build docker-push
4646

47-
.PHONY: all bootstrap glideup build test docker-build deploy build-server
47+
.PHONY: all bootstrap glideup build test docker-build deploy

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,12 @@ The Deis project welcomes contributions from all developers. The high level proc
3232
* If your PR fixes any [issues][issues], make sure you write Fixes #1234 in your PR description (where #1234 is the number of the issue you're closing)
3333
* The Deis core contributors will review your code. After each of them sign off on your code, they'll label your PR with `LGTM1` and `LGTM2` (respectively). Once that happens, you may merge.
3434

35+
## Minio Binary Mirror
36+
37+
Also, note that the [Dockerfile](rootfs/Dockerfile) uses an `ADD` directive to download pre-built Minio binaries from a [Google Cloud Storage bucket](https://console.cloud.google.com/storage/browser/minio-mirror/?project=deis-mirrors). The bucket is in the `deis-mirrors` project, and if you have access to that project, [this link](https://console.cloud.google.com/storage/browser/minio-mirror/?project=deis-mirrors) should take you directly to that bucket.
38+
39+
To bump this component to use a newer build of Minio, simply add a new binary to the bucket (under the `linux-amd64` folder), check the checkbox under the `Share publicly` column, and update the URL in the `ADD` directive in the aforementioned `Dockerfile`.
40+
3541
## Docker Based Development Environment
3642

3743
The preferred environment for development uses the [`go-dev` Docker image](https://github.com/deis/docker-go-dev). The tools described in this section are used to build, test, package and release each version of Deis.

rootfs/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ RUN curl -f -SL https://dl.minio.io/client/mc/release/linux-amd64/archive/mc.OFF
1313
&& chmod 755 /usr/bin/mc \
1414
&& mkdir /home/minio/.minio \
1515
&& chown minio:minio /home/minio/.minio
16-
ADD https://dl.minio.io/server/minio/release/linux-amd64/minio.RELEASE.2016-06-03T19-32-05Z /bin/minio
16+
ADD https://storage.googleapis.com/minio-mirror/linux-amd64/minio-2016-06-03T19-32-05Z /bin/minio
1717
RUN chmod 755 /bin/minio
1818

1919
USER minio

0 commit comments

Comments
 (0)