Skip to content

Commit 16a5e60

Browse files
committed
chore(monitor): optimize oauth2 configuration
1 parent 3fdb8c2 commit 16a5e60

2 files changed

Lines changed: 12 additions & 12 deletions

File tree

charts/monitor/templates/_helpers.tmpl

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,32 +42,32 @@ env:
4242
- name: {{ $key }}
4343
value: {{ $value | quote }}
4444
{{- end }}
45-
- name: "DRYCC_GRAFANA_DOMAIN"
45+
- name: "DRYCC_GRAFANA_URL"
4646
{{- if .Values.global.certManagerEnabled }}
4747
value: https://drycc-monitor-grafana.{{ .Values.global.platformDomain }}
4848
{{- else }}
4949
value: http://drycc-monitor-grafana.{{ .Values.global.platformDomain }}
5050
{{- end }}
51-
- name: "DRYCC_PASSPORT_DOMAIN"
51+
- name: "DRYCC_PASSPORT_URL"
5252
{{- if .Values.global.certManagerEnabled }}
5353
value: https://drycc-passport.{{ .Values.global.platformDomain }}
5454
{{- else }}
5555
value: http://drycc-passport.{{ .Values.global.platformDomain }}
5656
{{- end }}
5757
- name: "SOCIAL_AUTH_DRYCC_AUTHORIZATION_URL"
58-
value: "$(DRYCC_PASSPORT_DOMAIN)/oauth/authorize/"
58+
value: "$(DRYCC_PASSPORT_URL)/oauth/authorize/"
5959
- name: "SOCIAL_AUTH_DRYCC_ACCESS_TOKEN_URL"
60-
value: "$(DRYCC_PASSPORT_DOMAIN)/oauth/token/"
60+
value: "$(DRYCC_PASSPORT_URL)/oauth/token/"
6161
- name: "SOCIAL_AUTH_DRYCC_ACCESS_API_URL"
62-
value: "$(DRYCC_PASSPORT_DOMAIN)"
62+
value: "$(DRYCC_PASSPORT_URL)"
6363
- name: "SOCIAL_AUTH_DRYCC_USERINFO_URL"
64-
value: "$(DRYCC_PASSPORT_DOMAIN)/oauth/userinfo/"
65-
- name: SOCIAL_AUTH_DRYCC_GRAFANA_KEY
64+
value: "$(DRYCC_PASSPORT_URL)/oauth/userinfo/"
65+
- name: SOCIAL_AUTH_DRYCC_KEY
6666
valueFrom:
6767
secretKeyRef:
6868
name: passport-creds
6969
key: social-auth-drycc-grafana-key
70-
- name: SOCIAL_AUTH_DRYCC_GRAFANA_SECRET
70+
- name: SOCIAL_AUTH_DRYCC_SECRET
7171
valueFrom:
7272
secretKeyRef:
7373
name: passport-creds

grafana/rootfs/usr/share/grafana/grafana.ini.tpl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -231,11 +231,11 @@ config_file = "/usr/share/grafana/ldap.toml"
231231

232232
#################################### Generic Oauth ##########################
233233
[auth.generic_oauth]
234-
{{ if .SOCIAL_AUTH_DRYCC_GRAFANA_KEY }}
234+
{{ if .SOCIAL_AUTH_DRYCC_KEY }}
235235
name = OAuth
236236
enabled = true
237-
client_id = {{ .SOCIAL_AUTH_DRYCC_GRAFANA_KEY }}
238-
client_secret = {{ .SOCIAL_AUTH_DRYCC_GRAFANA_SECRET }}
237+
client_id = {{ .SOCIAL_AUTH_DRYCC_KEY }}
238+
client_secret = {{ .SOCIAL_AUTH_DRYCC_SECRET }}
239239
scopes = profile,openid
240240
auth_url = {{ .SOCIAL_AUTH_DRYCC_AUTHORIZATION_URL }}
241241
token_url = {{ .SOCIAL_AUTH_DRYCC_ACCESS_TOKEN_URL }}
@@ -246,7 +246,7 @@ role_attribute_path = (is_superuser && 'Admin') || (is_staff && 'Viewer') || ''
246246
role_attribute_strict = true
247247

248248
[server]
249-
root_url = {{ .DRYCC_GRAFANA_DOMAIN }}
249+
root_url = {{ .DRYCC_GRAFANA_URL }}
250250

251251
{{ end }}
252252

0 commit comments

Comments
 (0)