Skip to content

Commit 145ca6a

Browse files
author
Jonathan Chauncey
authored
Merge pull request #142 from jchauncey/remove-quote-call
chore(config): Remove calls to quote
2 parents a68ceab + 3aea2a7 commit 145ca6a

2 files changed

Lines changed: 14 additions & 10 deletions

File tree

telegraf/manifests/deis-monitor-telegraf-daemon.yaml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@ spec:
2222
fieldRef:
2323
fieldPath: metadata.namespace
2424
- name: "INFLUXDB_URLS"
25-
value: http://$(DEIS_MONITOR_INFLUXAPI_SERVICE_HOST):$(DEIS_MONITOR_INFLUXAPI_SERVICE_PORT_TRANSPORT)
25+
value: "\"http://$(DEIS_MONITOR_INFLUXAPI_SERVICE_HOST):$(DEIS_MONITOR_INFLUXAPI_SERVICE_PORT_TRANSPORT)\""
26+
- name: "INFLUXDB_INPUT_URLS"
27+
value: "\"http://$(DEIS_MONITOR_INFLUXAPI_SERVICE_HOST):$(DEIS_MONITOR_INFLUXAPI_SERVICE_PORT_TRANSPORT)/debug/vars\""
2628
- name: "HOST_PROC"
2729
value: "/rootfs/proc"
2830
- name: "HOST_SYS"
@@ -36,18 +38,20 @@ spec:
3638
- name: "ENABLE_PROMETHEUS"
3739
value: "true"
3840
- name: "NSQ_CONSUMER_SERVER"
39-
value: $(DEIS_NSQD_SERVICE_HOST):$(DEIS_NSQD_SERVICE_PORT_TRANSPORT)
41+
value: "$(DEIS_NSQD_SERVICE_HOST):$(DEIS_NSQD_SERVICE_PORT_TRANSPORT)"
4042
- name: "NSQ_CONSUMER_TOPIC"
4143
value: "metrics"
4244
- name: "NSQ_ENDPOINTS"
43-
value: http://$(DEIS_NSQD_SERVICE_HOST):$(DEIS_NSQD_SERVICE_PORT_HTTP)
45+
value: "\"http://$(DEIS_NSQD_SERVICE_HOST):$(DEIS_NSQD_SERVICE_PORT_HTTP)\""
46+
{{- if env "LOGGER_REDIS_LOCATION" | default .logger_redis_location | ne "off-cluster" }}
4447
- name: DEIS_LOGGER_REDIS_PASSWORD
4548
valueFrom:
4649
secretKeyRef:
4750
name: logger-redis-creds
4851
key: password
4952
- name: "REDIS_SERVERS"
50-
value: tcp://:$(DEIS_LOGGER_REDIS_PASSWORD)@$(DEIS_LOGGER_REDIS_SERVICE_HOST):$(DEIS_LOGGER_REDIS_SERVICE_PORT)
53+
value: "\"tcp://:$(DEIS_LOGGER_REDIS_PASSWORD)@$(DEIS_LOGGER_REDIS_SERVICE_HOST):$(DEIS_LOGGER_REDIS_SERVICE_PORT)\""
54+
{{- end }}
5155
volumeMounts:
5256
- mountPath: /var/run/docker.sock
5357
name: docker-socket

telegraf/rootfs/config.toml.tpl

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656

5757
{{ if .INFLUXDB_URLS}}
5858
[[outputs.influxdb]]
59-
urls = [{{ .INFLUXDB_URLS | quote }}]
59+
urls = [{{ .INFLUXDB_URLS }}]
6060
database = {{default "kubernetes" .INFLUXDB_DATABASE | quote }}
6161
precision = {{ default "ns" .INFLUXDB_PRECISION | quote }}
6262
timeout = {{ default "5s" .INFLUXDB_TIMEOUT | quote }}
@@ -68,7 +68,7 @@
6868

6969
{{ if .KAFKA_BROKERS}}
7070
[[outputs.kafka]]
71-
brokers = [{{ .KAFKA_BROKERS | quote }}]
71+
brokers = [{{ .KAFKA_BROKERS }}]
7272
topic = {{ default "telegraf" .KAFKA_TOPIC | quote }}
7373
routing_tag = {{ .KAFKA_ROUTING_TAG | quote }}
7474
{{ if .KAFKA_CERTIFICATE }} certificate = {{ .KAFKA_CERTIFICATE | quote }} {{ end }}
@@ -166,7 +166,7 @@
166166

167167
{{ if .ENABLE_INFLUXDB_INPUT }}
168168
[[inputs.influxdb]]
169-
urls = [{{ (print .INFLUXDB_URLS "/debug/vars") | quote }}]
169+
urls = [{{ .INFLUXDB_INPUT_URLS }}]
170170
{{ end }}
171171

172172
{{ if .MEMCACHED_SERVERS }}
@@ -191,7 +191,7 @@
191191

192192
{{ if .NSQ_ENDPOINTS }}
193193
[[inputs.nsq]]
194-
endpoints = [{{ .NSQ_ENDPOINTS | quote }}]
194+
endpoints = [{{ .NSQ_ENDPOINTS }}]
195195
interval = {{ default "1s" .AGENT_INTERVAL | quote }}
196196
{{ end }}
197197

@@ -210,7 +210,7 @@
210210

211211
{{ if .ENABLE_ETCD }}
212212
[[inputs.prometheus]]
213-
urls = [{{ (default "http://localhost:2379/metrics" .ETCD_URLS) }}]
213+
urls = [{{ .ETCD_URLS }}]
214214
{{ end }}
215215

216216
{{ if .RABBITMQ_URL }}
@@ -224,7 +224,7 @@
224224

225225
{{ if .REDIS_SERVERS }}
226226
[[inputs.redis]]
227-
servers = [{{ .REDIS_SERVERS | quote }}]
227+
servers = [{{ .REDIS_SERVERS }}]
228228
{{ end }}
229229

230230
{{ if .RETHINKDB_SERVERS }}

0 commit comments

Comments
 (0)