Skip to content
This repository was archived by the owner on Aug 17, 2023. It is now read-only.

Commit a9674a3

Browse files
committed
fix(charts) add quote around daemon_environment value
This change need to to avoid validation error when run helm install. Type of spec.template.spec.containers[].env[].value field must be string. how to test this change (it also reproduce problem) ``` $ cat<<EOS > values.yaml daemon_environment: SEND_LOGS_TO_NSQ: "true" EOS $ helm install --namespace deis-fluentd ./charts/fluentd -f values.yaml ``` Before this change, we got following error. > Error: error validating "": error validating data: expected type string, for field spec.template.spec.containers[0].env[0].value, got bool
1 parent 9caba5d commit a9674a3

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

charts/fluentd/templates/logger-fluentd-daemon.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ spec:
4242
{{- end}}
4343
{{- range $key, $value := .Values.daemon_environment }}
4444
- name: {{ $key }}
45-
value: {{ $value }}
45+
value: {{ $value | quote }}
4646
{{- end }}
4747
volumeMounts:
4848
- name: varlog

0 commit comments

Comments
 (0)