feat(tests) Add flake8 linting for python code (#91)

Fixes #8

Author: ultimateboy

.gitignore

@@ -0,0 +1,2 @@
+# python virtual environments for testing
+venv

.travis.yml

@@ -1,11 +1,13 @@
-language: go
-go:
-  - 1.5.1
+language: python
+python:
+  - "2.7"
 branches:
   only:
     - master
 services:
   - docker
 sudo: required
+install:
+  - pip install -r rootfs/dev_requirements.txt
 script:
-  - make docker-build
+  - make test docker-build

Makefile

@@ -9,7 +9,16 @@ docker-build:
 	docker build --rm -t ${IMAGE} rootfs
 	docker tag ${IMAGE} ${MUTABLE_IMAGE}
 
-test:
+setup-venv:
+	@if [ ! -d venv ]; then pyvenv venv && source venv/bin/activate; fi
+	pip install --disable-pip-version-check -q -r rootfs/dev_requirements.txt
+
+test: test-style test-functional
+
+test-style:
+	cd rootfs && flake8 --show-pep8 --show-source --config=setup.cfg .
+
+test-functional:
 	@echo "Implement functional tests in _tests directory"
 
 .PHONY: all build docker-compile kube-up kube-down deploy

rootfs/deploy.py

@@ -37,7 +37,8 @@ def log(msg):
 
 
 def get_registry_name():
-    hostname = os.getenv('DEIS_REGISTRY_HOSTNAME', "").replace("https://", "").replace("http://", "")
+    hostname = os.getenv('DEIS_REGISTRY_HOSTNAME', "")
+    hostname = hostname.replace("https://", "").replace("http://", "")
     if regsitryLocation == "off-cluster":
         organization = os.getenv('DEIS_REGISTRY_ORGANIZATION')
         regName = ""
@@ -52,9 +53,9 @@ def get_registry_name():
     elif regsitryLocation == "ecr":
         return hostname
     elif regsitryLocation == "gcr":
-        return hostname+"/"+os.getenv('DEIS_REGISTRY_GCS_PROJ_ID')
+        return hostname + "/" + os.getenv('DEIS_REGISTRY_GCS_PROJ_ID')
     else:
-        return os.getenv("DEIS_REGISTRY_SERVICE_HOST") + ":" + os.getenv("DEIS_REGISTRY_SERVICE_PORT")
+        return os.getenv("DEIS_REGISTRY_SERVICE_HOST") + ":" + os.getenv("DEIS_REGISTRY_SERVICE_PORT")  # noqa: E501
 
 
 def docker_push(client, repo, tag):
@@ -80,7 +81,13 @@ def download_file(tar_path):
         os.putenv('BUCKET_FILE', "/tmp/objectstore/minio/builder-bucket")
     elif os.getenv('BUILDER_STORAGE') in ["azure", "swift"]:
         os.putenv('CONTAINER_FILE', "/var/run/secrets/deis/objectstore/creds/builder-container")
-    command = ["objstorage", "--storage-type="+os.getenv('BUILDER_STORAGE'), "download", tar_path, "apptar"]
+    command = [
+        "objstorage",
+        "--storage-type="+os.getenv('BUILDER_STORAGE'),
+        "download",
+        tar_path,
+        "apptar"
+    ]
     subprocess.check_call(command)
 
 tar_path = os.getenv('TAR_PATH')

rootfs/dev_requirements.txt

@@ -0,0 +1,2 @@
+flake8==2.5.4
+

rootfs/setup.cfg

@@ -0,0 +1,4 @@
+[flake8]
+max-line-length = 99
+exclude = venv
+max-complexity = 12