Merge pull request #1122 from kmala/release

fix(release): Don't rollback if there is no build

Author: kmala

rootfs/api/models/app.py

@@ -498,7 +498,9 @@ def deploy(self, release, force_deploy=False, rollback_on_failure=True):  # noqa
             try:
                 async_run(tasks)
             except KubeException as e:
-                if rollback_on_failure:
+                # Don't rollback if the previous release doesn't have a build which means
+                # this is the first build and all the previous releases are just config changes.
+                if rollback_on_failure and release.previous().build is not None:
                     err = 'There was a problem deploying {}. Rolling back process types to release {}.'.format('v{}'.format(release.version), "v{}".format(release.previous().version))  # noqa
                     # This goes in the log before the rollback starts
                     self.log(err, logging.ERROR)

rootfs/api/tests/test_build.py

@@ -655,6 +655,8 @@ def test_build_deploy_kube_failure(self, mock_requests):
             url = "/v2/apps/{app_id}/builds".format(**locals())
             body = {'image': 'autotest/example'}
             response = self.client.post(url, body)
+            exp_error = {'detail': '(app::deploy): Boom!'}
+            self.assertEqual(response.data, exp_error, response.data)
             self.assertEqual(response.status_code, 400, response.data)
 
     def test_build_failures(self, mock_requests):