Skip to content

Commit f134fab

Browse files
committed
style(pep8): Use pep8-compliant code style
1 parent 69d052c commit f134fab

6 files changed

Lines changed: 27 additions & 22 deletions

File tree

rootfs/api/models/app.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -158,15 +158,15 @@ def _get_entrypoint(self, container_type):
158158
entrypoint = ['/bin/bash', '-c']
159159

160160
return entrypoint
161-
161+
162162
def _refresh_tls(self, certs_auto_enabled, hosts):
163163
namespace = name = self.id
164164
try:
165165
data = self._scheduler.certificate.get(namespace, name).json()
166166
except KubeException:
167167
self.log("certificate {} does not exist".format(namespace), level=logging.INFO)
168168
data = None
169-
169+
170170
if certs_auto_enabled:
171171
if data:
172172
version = data["metadata"]["resourceVersion"]
@@ -177,7 +177,7 @@ def _refresh_tls(self, certs_auto_enabled, hosts):
177177
namespace, name, settings.INGRESS_CLASS, hosts)
178178
elif data:
179179
self._scheduler.certificate.delete(namespace, name)
180-
180+
181181
def _refresh_ingress(self, hosts, tls_map, ssl_redirect):
182182
ingress = namespace = self.id
183183
# Put Ingress
@@ -187,7 +187,8 @@ def _refresh_ingress(self, hosts, tls_map, ssl_redirect):
187187
"ssl_redirect": ssl_redirect
188188
}
189189
whitelist = self.appsettings_set.latest().whitelist
190-
if whitelist: kwargs.update({"whitelist": whitelist})
190+
if whitelist:
191+
kwargs.update({"whitelist": whitelist})
191192
data = self._scheduler.ingress.get(namespace, ingress).json()
192193
version = data["metadata"]["resourceVersion"]
193194
self._scheduler.ingress.put(
@@ -217,9 +218,10 @@ def _refresh_ingress_and_tls(self):
217218
tls_map[secret_name].append(host)
218219
self._refresh_ingress(hosts, tls_map, ssl_redirect)
219220
self._refresh_tls(certs_auto_enabled, hosts)
220-
221+
221222
def refresh(self):
222-
if not getattr(self, "refresh_enabled", True): return
223+
if not getattr(self, "refresh_enabled", True):
224+
return
223225
self._refresh_ingress_and_tls()
224226

225227
def log(self, message, level=logging.INFO):

rootfs/api/models/tls.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,9 @@ def _check_previous_tls_settings(self):
3131
if previous_tls_settings.https_enforced == self.https_enforced:
3232
raise AlreadyExists(
3333
"{} changed nothing".format(self.owner))
34-
self.certs_auto_enabled = \
35-
previous_tls_settings.certs_auto_enabled
34+
self.certs_auto_enabled = previous_tls_settings.certs_auto_enabled
3635
elif self.certs_auto_enabled is not None:
37-
if previous_tls_settings.certs_auto_enabled == \
38-
self.certs_auto_enabled:
36+
if previous_tls_settings.certs_auto_enabled == self.certs_auto_enabled:
3937
raise AlreadyExists(
4038
"{} changed nothing".format(self.owner))
4139
self.https_enforced = previous_tls_settings.https_enforced
@@ -52,7 +50,5 @@ def save(self, *args, **kwargs):
5250
finally:
5351
self.app.refresh()
5452

55-
5653
def sync(self):
5754
self.app.refresh()
58-

rootfs/scheduler/resources/certificate.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
import json
21
from scheduler.resources import Resource
3-
from scheduler.exceptions import KubeHTTPException, KubeException
2+
from scheduler.exceptions import KubeHTTPException
43

54

65
class Certificate(Resource):
@@ -32,15 +31,17 @@ def manifest(self, namespace, name, ingress_class, hosts, version=None):
3231
}
3332
}
3433
}
35-
if version: data["metadata"]["resourceVersion"] = version
34+
if version:
35+
data["metadata"]["resourceVersion"] = version
3636
return data
3737

3838
def get(self, namespace, name=None, **kwargs):
3939
"""
4040
Fetch a single certificate or a list of certificates
4141
"""
4242
if name is not None:
43-
url = "/apis/certmanager.k8s.io/v1alpha1/namespaces/%s/certificates/%s" % (namespace, name)
43+
url = "/apis/certmanager.k8s.io/v1alpha1/namespaces/%s/certificates/%s" % (
44+
namespace, name)
4445
message = 'get certificate ' + name
4546
else:
4647
url = "/apis/certmanager.k8s.io/v1alpha1/namespaces/%s/certificates" % namespace
@@ -78,4 +79,4 @@ def delete(self, namespace, name):
7879
response = self.http_delete(url)
7980
if self.unhealthy(response.status_code):
8081
raise KubeHTTPException(response, 'delete certificate ' + name)
81-
return response
82+
return response

rootfs/scheduler/resources/ingress.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,10 @@ def manifest(self, ingress, ingress_class, namespace, **kwargs):
4040
data["metadata"]["annotations"].update({
4141
"kubernetes.io/ingress.class": ingress_class
4242
})
43-
if tls: data["spec"]["tls"] = tls
44-
if version: data["metadata"]["resourceVersion"] = version
43+
if tls:
44+
data["spec"]["tls"] = tls
45+
if version:
46+
data["metadata"]["resourceVersion"] = version
4547
return data
4648

4749

@@ -61,6 +63,8 @@ def manifest(self, ingress, ingress_class, namespace, **kwargs):
6163
"nginx.ingress.kubernetes.io/ssl-redirect": ssl_redirect
6264
})
6365
return data
66+
67+
6468
MANIFEAT_CLASSES["nginx"] = NginxManifest
6569

6670

@@ -81,6 +85,8 @@ def manifest(self, ingress, ingress_class, namespace, **kwargs):
8185
"ingress.kubernetes.io/ssl-redirect": ssl_redirect
8286
})
8387
return data
88+
89+
8490
MANIFEAT_CLASSES["traefik"] = TraefikManifest
8591

8692

rootfs/scheduler/resources/secret.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,4 +112,4 @@ def delete(self, namespace, name):
112112
'delete Secret "{}" in Namespace "{}"', name, namespace
113113
)
114114

115-
return response
115+
return response

rootfs/scheduler/tests/test_ingress.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ class IngressTest(TestCase):
1313
def test_create_ingress(self):
1414
# Ingress assumes that the namespace and ingress name are always the same
1515
self.scheduler.ns.create("test-ingress")
16-
self.scheduler.ingress.create("test-ingress", "nginx", "test-ingress",
17-
hosts=["test-ingress"], tls=[])
16+
self.scheduler.ingress.create(
17+
"test-ingress", "nginx", "test-ingress", hosts=["test-ingress"], tls=[])
1818

1919
def test_get_ingresses(self):
2020
response = self.scheduler.ingress.get("test-ingress")

0 commit comments

Comments
 (0)