Add negative test for quota api call

Author: v-reyder

rootfs/api/models/app.py

@@ -203,6 +203,7 @@ def create(self, *args, **kwargs):  # noqa
         # create required minimum resources in k8s for the application
         namespace = self.id
         service = self.id
+        quota_name = '{}-quota'.format(self.id)
         try:
             self.log('creating Namespace {} and services'.format(namespace), level=logging.DEBUG)
             # Create essential resources
@@ -212,8 +213,6 @@ def create(self, *args, **kwargs):  # noqa
                 self._scheduler.ns.create(namespace)
 
             if settings.KUBERNETES_NAMESPACE_DEFAULT_QUOTA_SPEC != '':
-                quota_name = '{}-quota'.format(namespace)
-                self.log(settings.KUBERNETES_NAMESPACE_DEFAULT_QUOTA_SPEC)
                 quota_spec = json.loads(settings.KUBERNETES_NAMESPACE_DEFAULT_QUOTA_SPEC)
                 self.log('creating Quota {} for namespace {}'.format(quota_name, namespace),
                          level=logging.DEBUG)

rootfs/api/settings/testing.py

@@ -36,3 +36,4 @@
 
 # How long k8s waits for a pod to finish work after a SIGTERM before sending SIGKILL
 KUBERNETES_POD_TERMINATION_GRACE_PERIOD_SECONDS = int(os.environ.get('KUBERNETES_POD_TERMINATION_GRACE_PERIOD_SECONDS', 2))  # noqa
+KUBERNETES_NAMESPACE_DEFAULT_QUOTA_SPEC = '{"spec":{"hard":{"pods":"10"}}}'

rootfs/scheduler/tests/test_quota.py

@@ -4,6 +4,7 @@
 Run the tests with './manage.py test scheduler'
 """
 from scheduler.tests import TestCase
+from scheduler import KubeHTTPException
 
 
 class QuotaTest(TestCase):
@@ -25,3 +26,10 @@ def test_create_quota(self):
         data = response.json()
         self.assertEqual(data.get('spec', {}), quota['spec'])
         self.assertEqual(data['metadata']['namespace'], namespace_name)
+
+    def test_create_with_nonexistent_namespace(self):
+        with self.assertRaises(
+            KubeHTTPException,
+            msg='failed to create quota test1 for namespace ghost-namespace: 404 Not Found'
+        ):
+            self.scheduler.quota.create('ghost-namespace', 'test1', data={})