chore(tests): improve coverage by triggering KubeExceptions (and other types)

Author: helgi

rootfs/api/tests/test_app.py

@@ -14,6 +14,7 @@
 from rest_framework.authtoken.models import Token
 
 from api.models import App
+from scheduler import KubeException
 
 from . import adapter
 import requests_mock
@@ -266,9 +267,7 @@ def test_run(self, mock_requests):
         A user should be able to run a one off command
         """
         app_id = 'autotest'
-        url = '/v2/apps'
-        body = {'id': app_id}
-        response = self.client.post(url, body)
+        response = self.client.post('/v2/apps', {'id': app_id})
 
         # create build
         body = {'image': 'autotest/example'}
@@ -284,6 +283,25 @@ def test_run(self, mock_requests):
         self.assertEqual(response.data['rc'], 0)
         self.assertEqual(response.data['output'], 'mock')
 
+    def test_run_failure(self, mock_requests):
+        """Raise a KubeException via scheduler.run"""
+        app_id = 'autotest'
+        response = self.client.post('/v2/apps', {'id': app_id})
+
+        # create build
+        body = {'image': 'autotest/example'}
+        url = '/v2/apps/{app_id}/builds'.format(**locals())
+        response = self.client.post(url, body)
+        self.assertEqual(response.status_code, 201)
+
+        with mock.patch('scheduler.KubeHTTPClient.run') as kube_run:
+            kube_run.side_effect = KubeException('boom!')
+            # run command
+            url = '/v2/apps/{}/run'.format(app_id)
+            body = {'command': 'ls -al'}
+            response = self.client.post(url, body)
+            self.assertEqual(response.status_code, 503)
+
     def test_unauthorized_user_cannot_see_app(self, mock_requests):
         """
         An unauthorized user should not be able to access an app's resources.
@@ -384,6 +402,30 @@ def test_app_exists_in_kubernetes(self, mock_requests):
             status_code=409
         )
 
+    def test_app_create_failure_kubernetes_create(self, mock_requests):
+        """
+        Create an app but have scheduler.create fail with an exception
+        """
+        with mock.patch('scheduler.KubeHTTPClient.create') as mock_kube:
+            mock_kube.side_effect = KubeException('Boom!')
+            response = self.client.post('/v2/apps', {'id': 'test-kube'})
+            self.assertEqual(response.status_code, 503)
+
+    def test_app_delete_failure_kubernetes_destroy(self, mock_requests):
+        """
+        Create an app and then delete but have scheduler.destroy
+        fail with an exception
+        """
+        # create
+        response = self.client.post('/v2/apps', {'id': 'test'})
+        self.assertEqual(response.status_code, 201)
+
+        with mock.patch('scheduler.KubeHTTPClient.destroy') as mock_kube:
+            # delete
+            mock_kube.side_effect = KubeException('Boom!')
+            response = self.client.delete('/v2/apps/test')
+            self.assertEqual(response.status_code, 503)
+
     def test_app_verify_application_health_success(self, mock_requests):
         """
         Create an application which in turn causes a health check to run against

rootfs/api/tests/test_build.py

@@ -15,6 +15,8 @@
 from rest_framework.authtoken.models import Token
 
 from api.models import Build
+from registry.dockerclient import RegistryException
+from scheduler import KubeException
 
 from . import adapter
 import requests_mock
@@ -346,3 +348,78 @@ def test_build_image_in_registry(self, mock_requests):
         release = build.app.release_set.latest()
         # Registry host + port is internally stripped off
         self.assertEqual(release.image, 'autotest/example')
+
+    def test_build_image_in_registry_with_auth(self, mock_requests):
+        """add authentication to the build"""
+        self.client.post('/v2/apps', {'id': 'test'})
+
+        # post an image as a build using registry hostname
+        url = "/v2/apps/test/builds"
+        image = 'autotest/example'
+        response = self.client.post(url, {'image': image})
+        self.assertEqual(response.status_code, 201)
+
+        # set some registry information
+        url = '/v2/apps/test/config'
+        body = {'registry': json.dumps({'username': 'bob', 'password': 'zoomzoom'})}
+        response = self.client.post(url, body)
+        self.assertEqual(response.status_code, 201)
+
+    def test_release_create_failure(self, mock_requests):
+        """
+        Cause an Exception in app.deploy to cause a release.delete in build.create
+        """
+        body = {'id': 'test'}
+        self.client.post('/v2/apps', body)
+
+        # deploy app to get a build
+        url = "/v2/apps/test/builds"
+        body = {'image': 'autotest/example'}
+        response = self.client.post(url, body)
+        self.assertEqual(response.status_code, 201)
+        self.assertEqual(response.data['image'], body['image'])
+
+        with mock.patch('api.models.App.deploy') as mock_deploy:
+            mock_deploy.side_effect = Exception('Boom!')
+
+            url = "/v2/apps/test/builds"
+            body = {'image': 'autotest/example'}
+            response = self.client.post(url, body)
+            self.assertEqual(response.status_code, 400)
+
+    def test_release_registry_create_failure(self, mock_requests):
+        """
+        Cause a RegistryException in app.deploy to cause a release.delete in build.create
+        """
+        body = {'id': 'test'}
+        self.client.post('/v2/apps', body)
+
+        # deploy app to get a build
+        url = "/v2/apps/test/builds"
+        body = {'image': 'autotest/example'}
+        response = self.client.post(url, body)
+        self.assertEqual(response.status_code, 201)
+        self.assertEqual(response.data['image'], body['image'])
+
+        with mock.patch('api.models.Release.publish') as mock_registry:
+            mock_registry.side_effect = RegistryException('Boom!')
+
+            url = "/v2/apps/test/builds"
+            body = {'image': 'autotest/example'}
+            response = self.client.post(url, body)
+            self.assertEqual(response.status_code, 400)
+
+    def test_build_deploy_kube_failure(self, mock_requests):
+        """
+        Cause an Exception in scheduler.deploy
+        """
+        body = {'id': 'test'}
+        self.client.post('/v2/apps', body)
+
+        with mock.patch('scheduler.KubeHTTPClient.deploy') as mock_deploy:
+            mock_deploy.side_effect = KubeException('Boom!')
+
+            url = "/v2/apps/test/builds"
+            body = {'image': 'autotest/example'}
+            response = self.client.post(url, body)
+            self.assertEqual(response.status_code, 400)

rootfs/api/tests/test_certificate_use_case_1.py

@@ -110,12 +110,18 @@ def test_get_certificate_screens_data(self):
         for key, value in list(expected.items()):
             self.assertEqual(response.data[key], value, key)
 
-        # detach domain to certificate
+        # detach domain from a certificate
         response = self.client.delete(
             '{}/{}/domain/{}'.format(self.url, self.name, self.domain)
         )
         self.assertEqual(response.status_code, 204)
 
+        # detach a domain that does not exist from a certificate
+        response = self.client.delete(
+            '{}/{}/domain/{}'.format(self.url, self.name, 'i-am-fake.com')
+        )
+        self.assertEqual(response.status_code, 404)
+
         # Assert data
         response = self.client.get('{}/{}'.format(self.url, self.name))
         self.assertEqual(response.status_code, 200)

rootfs/api/tests/test_config.py

@@ -237,6 +237,29 @@ def test_valid_config_keys(self, mock_requests):
             self.assertEqual(resp.status_code, 201)
             self.assertIn(k, resp.data['values'])
 
+    def test_config_deploy_failure(self, mock_requests):
+        """
+        Cause an Exception in app.deploy to cause a release.delete
+        """
+        url = '/v2/apps'
+        response = self.client.post(url)
+        self.assertEqual(response.status_code, 201)
+        app_id = response.data['id']
+
+        # deploy app to get a build
+        url = "/v2/apps/{}/builds".format(app_id)
+        body = {'image': 'autotest/example'}
+        response = self.client.post(url, body)
+        self.assertEqual(response.status_code, 201)
+        self.assertEqual(response.data['image'], body['image'])
+
+        with mock.patch('api.models.App.deploy') as mock_deploy:
+            mock_deploy.side_effect = Exception('Boom!')
+            url = '/v2/apps/{app_id}/config'.format(**locals())
+            body = {'values': json.dumps({'test': "testvalue"})}
+            resp = self.client.post(url, body)
+            self.assertEqual(resp.status_code, 400)
+
     def test_invalid_config_keys(self, mock_requests):
         """Test that invalid config keys are rejected.
         """
@@ -548,6 +571,13 @@ def test_tags(self, mock_requests):
         body = {'tags': json.dumps({'host.name.com/,not.valid': 'valid'})}
         response = self.client.post(url, body)
         self.assertEqual(response.status_code, 400)
+        long_tag = 'a' * 300
+        body = {'tags': json.dumps({'{}/not.valid'.format(long_tag): 'valid'})}
+        response = self.client.post(url, body)
+        self.assertEqual(response.status_code, 400)
+        body = {'tags': json.dumps({'this&foo.com/not.valid': 'valid'})}
+        response = self.client.post(url, body)
+        self.assertEqual(response.status_code, 400)
 
         # disallow put/patch/delete
         response = self.client.put(url)
@@ -619,6 +649,12 @@ def test_registry(self, mock_requests):
         self.assertNotEqual(registry3['uuid'], registry4['uuid'])
         self.assertNotIn('password', json.dumps(response.data['registry']))
 
+        # bad registry key values
+        body = {'registry': json.dumps({'pa$$w0rd': 'woop'})}
+        response = self.client.post(url, body)
+        response = self.client.post(url, body)
+        self.assertEqual(response.status_code, 400)
+
         # disallow put/patch/delete
         response = self.client.put(url)
         self.assertEqual(response.status_code, 405)