Skip to content

Commit d27cbff

Browse files
committed
Merge pull request #713 from helgi/fingerprint_k8s
fix(scheduler): use CA cert to verify API SSL certficiate
2 parents 0667019 + fd7cabc commit d27cbff

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

rootfs/deis/settings.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,8 @@
254254
# default scheduler settings
255255
SCHEDULER_MODULE = 'scheduler'
256256
SCHEDULER_URL = "https://{}:{}".format(
257+
# accessing the k8s api server by IP address rather than hostname avoids
258+
# intermittent DNS errors
257259
os.environ.get('KUBERNETES_SERVICE_HOST', 'kubernetes.default.svc.cluster.local'),
258260
os.environ.get('KUBERNETES_SERVICE_PORT', '443')
259261
)

rootfs/scheduler/__init__.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -337,11 +337,7 @@ def __init__(self):
337337
'Content-Type': 'application/json',
338338
'User-Agent': user_agent('Deis Controller', deis_version)
339339
}
340-
# TODO: accessing the k8s api server by IP address rather than hostname avoids
341-
# TODO look at https://toolbelt.readthedocs.org/en/latest/adapters.html#fingerprintadapter
342-
# intermittent DNS errors, but at the price of disabling cert verification.
343-
# session.verify = '/var/run/secrets/kubernetes.io/serviceaccount/ca.crt'
344-
session.verify = False
340+
session.verify = '/var/run/secrets/kubernetes.io/serviceaccount/ca.crt'
345341
self.session = session
346342

347343
def deploy(self, namespace, name, image, command, **kwargs): # noqa

0 commit comments

Comments
 (0)