Skip to content

Commit cb34ba7

Browse files
author
Aaron Schlesinger
committed
fix(README.md): prefer to use the make deploy command
1 parent e6cc41b commit cb34ba7

1 file changed

Lines changed: 4 additions & 21 deletions

File tree

README.md

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -71,35 +71,18 @@ Also, since this component is central to the platform, it's recommended that you
7171
* `SHORT_NAME` (optional) - The name of the image. This defaults to `controller`
7272
* `VERSION` (optional) - The tag of the Docker image. This defaults to the current Git SHA (the output of `git rev-parse --short HEAD`)
7373

74-
Then, run the following commands to build and push a new Docker image with your changes, and install it on your Kubernetes cluster.
75-
76-
```console
77-
make docker-build docker-push
78-
```
79-
80-
See below for a complete example with appropriate environment variables.
74+
Then, run `make deploy` to build and push a new Docker image with your changes and replace the existing one with your new one in the Kubernetes cluster. See below for an example with appropriate environment variables.
8175

8276
```console
8377
export DEIS_REGISTRY=quay.io/
8478
export IMAGE_PREFIX=arschles
85-
make docker-build docker-push
86-
```
87-
88-
Once the Docker push is complete, edit `$(helm home)/workspace/charts/deis-dev/manifests/deis-controller-rc.yaml` so that the `image:` field has the complete location of your Docker image (for example, the image produced by the previous command would be similar to `quay.io/arschles/controller:bba8eca`.)
89-
90-
Finally, delete and re-create the Deis controller [Replication Controller][repl-controller]:
91-
92-
```console
93-
kubectl delete rc deis-controller --namespace=deis
94-
kubectl create -f $(helm home)/workspace/charts/deis-dev/manifests/deis-controller-rc.yaml
79+
make deploy
9580
```
9681

97-
Note: if you used the stable release of the Deis chart, the path to the `deis-controller-rc.yaml` will be `Note that if you used the stable release of the Deis chart, the path will be `$(helm home)/workspace/charts/deis/manifests/deis-controller-rc.yaml`.
98-
99-
Once you've re-created the replication controller, a new pod will be launched by it. You'll need to wait until the pod is listed as `Running` and the value in its `Ready` column is `1/1`. Use the following command to check the Pod's status:
82+
After the `make deploy` finishes, a new pod will be launched but may not be running. You'll need to wait until the pod is listed as `Running` and the value in its `Ready` column is `1/1`. Use the following command to check the Pod's status:
10083

10184
```console
102-
kubectl get pod --namespace=deis
85+
kubectl get pod --namespace=deis | grep deis-controller
10386
```
10487

10588
## License

0 commit comments

Comments
 (0)