fix(controller): miss service error

Author: duanhongyi

rootfs/api/signals.py

@@ -178,7 +178,7 @@ def gateway_changed_handle(
 @receiver(signal=[post_save, post_delete], sender=Service)
 def service_changed_handle(
         sender, instance: Service, created=False, update_fields=None, **kwargs):
-    if not created and update_fields is None:  # delete
+    if kwargs['signal'] == post_delete:
         instance.app.route_set.filter(procfile_type=instance.procfile_type).delete()
 
 
@@ -203,9 +203,10 @@ def appsettings_changed_handle(
             elif action == "remove":
                 instance.app.cleanup_old()
         for procfile_type in canaries:
+            canary = (action == "append")
             service = instance.app.service_set.filter(procfile_type=procfile_type).first()
-            if service is not None:
-                service.canary = action == "append"
+            if service is not None and service.canary != canary:
+                service.canary = canary
                 service.save()
         if prev_settings.routable != instance.routable:
             for route in instance.app.route_set.all():

rootfs/api/tests/test_app_settings.py

@@ -175,23 +175,38 @@ def test_settings_labels(self, mock_requests):
 
     def test_canaries(self, mock_requests):
         app_id = self.create_app()
+        app = App.objects.get(id=app_id)
+        expect = ["web", "task", "new", "apps"]
+        for index, scale_type in enumerate(expect):
+            response = self.client.post(
+                '/v2/apps/{}/services'.format(app_id),
+                {
+                    'port': 5000 + index,
+                    'protocol': 'TCP',
+                    'target_port': 5000 + index,
+                    'procfile_type': scale_type
+                }
+            )
+            self.assertEqual(response.status_code, 201, response.data)
         self.client.post(
             f'/v2/apps/{app_id}/settings',
-            {'canaries': ["web", "task"]}
+            {'canaries': expect[:2]}
         )
         response = self.client.post(
             f'/v2/apps/{app_id}/settings',
-            {'canaries': ["new", "apps"]}
+            {'canaries': expect[2:]}
         )
+        expect = ["web", "task", "new", "apps"]
         self.assertEqual(
             response.json()["canaries"],
-            ["web", "task", "new", "apps"],
+            expect,
             response.data
         )
+
+        self.assertEqual(len(app.service_set.all()), 4)
         response = self.client.delete(
             f'/v2/apps/{app_id}/settings',
             {'canaries': ["new", "apps"]}
         )
-        app = App.objects.get(id=app_id)
         app_settings = app.appsettings_set.latest()
         self.assertEqual(app_settings.canaries, ["web", "task"])