fix(app): check if app name already exists in kubernetes during app creation

Fixes #316

Author: helgi

rootfs/api/models/app.py

@@ -11,7 +11,7 @@
 from django.core.exceptions import ValidationError
 from jsonfield import JSONField
 
-from api.models import UuidAuditedModel, log_event
+from api.models import UuidAuditedModel, log_event, AlreadyExists
 from api.utils import generate_app_name, app_build_type
 from api.models.release import Release
 from api.models.config import Config
@@ -71,6 +71,20 @@ def save(self, *args, **kwargs):
             while App.objects.filter(id=self.id).exists():
                 self.id = generate_app_name()
 
+        # verify the application name doesn't exist as a k8s namespace
+        # only check for it if there have been on releases
+        try:
+            self.release_set.latest()
+        except Release.DoesNotExist:
+            try:
+                if self._scheduler._get_namespace(self.id).status_code == 200:
+                    # Namespace already exists
+                    err = "{} already exists as a namespace in this kuberenetes setup".format(self.id)  # noqa
+                    log_event(self, err, logging.INFO)
+                    raise AlreadyExists(err)
+            except KubeHTTPException:
+                pass
+
         application = super(App, self).save(**kwargs)
 
         # create all the required resources
@@ -310,12 +324,12 @@ def _scale_pods(self, scale_types):
 
     def deploy(self, user, release):
         """Deploy a new release to this application"""
-        # use create to make sure minimum resources are created
-        self.create()
-
         if release.build is None:
             raise EnvironmentError('No build associated with this release')
 
+        # use create to make sure minimum resources are created
+        self.create()
+
         if self.structure == {}:
             self.structure = self._default_structure(release)
             self.save()

rootfs/api/tests/test_app.py

@@ -364,6 +364,17 @@ def test_app_transfer(self):
         self.assertEqual(response.status_code, 200)
         self.assertEqual(response.data['owner'], self.user.username)
 
+    def test_app_exists_in_kubernetes(self):
+        """
+        Create an app that has the same namespace as an existing kubernetes namespace
+        """
+        body = {'id': 'duplicate'}
+        response = self.client.post('/v2/apps', body)
+        self.assertContains(
+            response,
+            'duplicate already exists as a namespace in this kuberenetes setup',
+            status_code=409
+        )
 
 FAKE_LOG_DATA = """
 2013-08-15 12:41:25 [33454] [INFO] Starting gunicorn 17.5

rootfs/api/views.py

@@ -203,6 +203,14 @@ class AppViewSet(BaseDeisViewSet):
     def get_queryset(self, *args, **kwargs):
         return self.model.objects.all(*args, **kwargs)
 
+    def create(self, request, **kwargs):
+        try:
+            return super(AppViewSet, self).create(request, **kwargs)
+        except AlreadyExists as e:
+            return Response({'detail': str(e)}, status=status.HTTP_409_CONFLICT)
+        except EnvironmentError as e:
+            return Response({'detail': str(e)}, status=status.HTTP_400_BAD_REQUEST)
+
     def list(self, request, *args, **kwargs):
         """
         HACK: Instead of filtering by the queryset, we limit the queryset to list only the apps

rootfs/scheduler/mock.py

@@ -420,6 +420,11 @@ def __init__(self):
             }
             self._create_secret('deis', 'minio-user', secrets)
 
+        try:
+            self._get_namespace('duplicate')
+        except KubeHTTPException:
+            self._create_namespace('duplicate')
+
         try:
             self._get_node('172.17.8.100')
         except KubeHTTPException: