Merge pull request #1116 from kmala/registration

fix(registration): allow admin user registration when the mode is admin_only

Author: kmala

rootfs/api/permissions.py

@@ -2,7 +2,7 @@
 from rest_framework import exceptions
 from rest_framework import permissions
 from django.conf import settings
-from django.contrib.auth.models import AnonymousUser
+from django.contrib.auth.models import AnonymousUser, User
 
 from api import models
 
@@ -109,6 +109,8 @@ def has_permission(self, request, view):
             if settings.REGISTRATION_MODE == 'enabled':
                 return True
             elif settings.REGISTRATION_MODE == 'admin_only':
+                if not User.objects.filter(is_superuser=True).exists():
+                    return True
                 return request.user.is_superuser
             else:
                 raise Exception("{} is not a valid registation mode"

rootfs/api/tests/test_perm.py

@@ -1,5 +1,6 @@
 from django.contrib.auth.models import User
 from rest_framework.authtoken.models import Token
+from django.test.utils import override_settings
 from api.tests import DeisTestCase
 
 
@@ -32,6 +33,21 @@ def test_first_signup(self):
         self.assertEqual(response.status_code, 201, response.data)
         self.assertFalse(response.data['is_superuser'])
 
+    @override_settings(REGISTRATION_MODE="admin_only")
+    def test_first_signup_admin_only(self):
+        # register a first user
+        username, password = 'firstuser', 'password'
+        email = 'autotest@deis.io'
+        submit = {
+            'username': username,
+            'password': password,
+            'email': email,
+        }
+        url = '/v2/auth/register'
+        response = self.client.post(url, submit)
+        self.assertEqual(response.status_code, 201, response.data)
+        self.assertTrue(response.data['is_superuser'])
+
     def test_list(self):
         submit = {
             'username': 'firstuser',