fix(healthcheck): URL is required but set_healthcheck did not account for that

Author: helgi

rootfs/api/models/config.py

@@ -61,6 +61,8 @@ def set_healthchecks(self):
         # fetch set health values and any defaults
         # this approach allows new health items to be added without issues
         health = self.healthcheck()
+        if not health:
+            return
 
         # HTTP GET related
         self.values['HEALTHCHECK_URL'] = health['path']

rootfs/api/tests/test_config.py

@@ -644,6 +644,16 @@ def test_healthchecks(self, mock_requests):
         self.assertEqual(response.status_code, 201)
         app_id = response.data['id']
 
+        # Set healthcheck URL to get defaults set
+        body = {'values': json.dumps({'HEALTHCHECK_INITIAL_DELAY': '25'})}
+        resp = self.client.post(
+            '/v2/apps/{app_id}/config'.format(**locals()),
+            body
+        )
+        self.assertEqual(resp.status_code, 201)
+        self.assertIn('HEALTHCHECK_INITIAL_DELAY', resp.data['values'])
+        self.assertEqual(resp.data['values']['HEALTHCHECK_INITIAL_DELAY'], '25')
+
         # Set healthcheck URL to get defaults set
         body = {'values': json.dumps({'HEALTHCHECK_URL': '/health'})}
         resp = self.client.post(