fix(controller): volume repeat path no error

Author: duanhongyi

rootfs/api/models/volume.py

@@ -30,7 +30,7 @@ def save(self, *args, **kwargs):
         if self.type == "csi" and self.created == self.updated:
             self._create_pvc()
         # check path
-        self._check_path()
+        self.check_path()
         # Save to DB
         return super(Volume, self).save(*args, **kwargs)
 
@@ -99,7 +99,7 @@ def _format_size(size):
             size = size.upper() + "i"
         return size
 
-    def _check_path(self):
+    def check_path(self, path=None):
         other_volumes = self.app.volume_set.exclude(name=self.name)
         type_paths = {}  # {'type1':[path1,path2], tyep2:[path3,path4]}
         for _ in other_volumes:
@@ -108,10 +108,12 @@ def _check_path(self):
                     type_paths[k] = [v]
                 else:
                     type_paths[k].append(v)
-        repeat_path = [v for k, v in self.path.items() if v in type_paths.get(k, [])]
+        items = path.items() if path else self.path.items()
+        repeat_path = [v for k, v in items if v in type_paths.get(k, [])]
         if repeat_path:
-            raise DryccException("path {} is used by another volume".
-                                 format(','.join(repeat_path)))
+            msg = "path {} is used by another volume".format(','.join(repeat_path))
+            self.log(msg, logging.ERROR)
+            raise DryccException(msg)
 
     def _create_pvc(self):
         try:

rootfs/api/views.py

@@ -726,6 +726,7 @@ def path(self, request, *args, **kwargs):
                                  format(','.join(container_types)))
         if set(path.items()).issubset(set(volume.path.items())):
             raise DryccException("mount path not changed")
+        volume.check_path(path)
 
         app = self.get_app()
         mount_app.delay(app, self.request.user, volume, path)