Skip to content

Commit 899e008

Browse files
author
Matthew Fisher
authored
fix(models): add "_added" log function, lowercase class name (#1017)
This change caused e2e to fail because it expects the class name to be lower case.
1 parent 50811a2 commit 899e008

1 file changed

Lines changed: 15 additions & 5 deletions

File tree

rootfs/api/models/__init__.py

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,17 @@ class Meta:
130130
def _log_instance_created(**kwargs):
131131
if kwargs.get('created'):
132132
instance = kwargs['instance']
133-
message = '{} {} created'.format(instance.__class__.__name__, instance)
133+
message = '{} {} created'.format(instance.__class__.__name__.lower(), instance)
134+
if hasattr(instance, 'app'):
135+
instance.app.log(message)
136+
else:
137+
logger.info(message)
138+
139+
140+
def _log_instance_added(**kwargs):
141+
if kwargs.get('created'):
142+
instance = kwargs['instance']
143+
message = '{} {} added'.format(instance.__class__.__name__.lower(), instance)
134144
if hasattr(instance, 'app'):
135145
instance.app.log(message)
136146
else:
@@ -139,7 +149,7 @@ def _log_instance_created(**kwargs):
139149

140150
def _log_instance_updated(**kwargs):
141151
instance = kwargs['instance']
142-
message = '{} {} updated'.format(instance.__class__.__name__, instance)
152+
message = '{} {} updated'.format(instance.__class__.__name__.lower(), instance)
143153
if hasattr(instance, 'app'):
144154
instance.app.log(message)
145155
else:
@@ -148,7 +158,7 @@ def _log_instance_updated(**kwargs):
148158

149159
def _log_instance_removed(**kwargs):
150160
instance = kwargs['instance']
151-
message = '{} {} removed'.format(instance.__class__.__name__, instance)
161+
message = '{} {} removed'.format(instance.__class__.__name__.lower(), instance)
152162
if hasattr(instance, 'app'):
153163
instance.app.log(message)
154164
else:
@@ -167,8 +177,8 @@ def _log_release_created(**kwargs):
167177
post_save.connect(_log_release_created, sender=Release, dispatch_uid='api.models.log')
168178

169179
post_save.connect(_log_instance_created, sender=Build, dispatch_uid='api.models.log')
170-
post_save.connect(_log_instance_created, sender=Certificate, dispatch_uid='api.models.log')
171-
post_save.connect(_log_instance_created, sender=Domain, dispatch_uid='api.models.log')
180+
post_save.connect(_log_instance_added, sender=Certificate, dispatch_uid='api.models.log')
181+
post_save.connect(_log_instance_added, sender=Domain, dispatch_uid='api.models.log')
172182

173183
post_save.connect(_log_instance_updated, sender=AppSettings, dispatch_uid='api.models.log')
174184
post_save.connect(_log_instance_updated, sender=Config, dispatch_uid='api.models.log')

0 commit comments

Comments
 (0)