Skip to content

Commit 8833963

Browse files
authored
Merge pull request #1174 from kmala/fix
fix(domain): remove the annotation when domain is deleted
2 parents 6d13723 + 9f4543b commit 8833963

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

rootfs/api/models/domain.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,10 @@ def delete(self, *args, **kwargs):
4949
app = str(self.app)
5050
domain = str(self.domain)
5151

52+
# Deatch cert, updates k8s
53+
if self.certificate:
54+
self.certificate.detach(domain=domain)
55+
5256
# get config for the service
5357
config = self._load_service_config(app, 'router')
5458

@@ -64,10 +68,6 @@ def delete(self, *args, **kwargs):
6468

6569
self._save_service_config(app, 'router', config)
6670

67-
# Deatch cert, updates k8s
68-
if self.certificate:
69-
self.certificate.detach(domain=str(self.domain))
70-
7171
# Delete from DB
7272
return super(Domain, self).delete(*args, **kwargs)
7373

0 commit comments

Comments
 (0)