Skip to content

Commit 8480f69

Browse files
committed
fix(app.py): use current namespace instead of "deis"
1 parent 4e83f4d commit 8480f69

3 files changed

Lines changed: 11 additions & 2 deletions

File tree

charts/controller/templates/controller-deployment.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,10 @@ spec:
125125
key: password
126126
- name: RESERVED_NAMES
127127
value: "deis, deis-builder, deis-workflow-manager, grafana"
128+
- name: WORKFLOW_NAMESPACE
129+
valueFrom:
130+
fieldRef:
131+
fieldPath: metadata.namespace
128132
volumeMounts:
129133
- mountPath: /var/run/docker.sock
130134
name: docker-socket

rootfs/api/models/app.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -992,7 +992,8 @@ def _get_private_registry_config(self, image, registry=None):
992992
username = registry.get('username')
993993
password = registry.get('password')
994994
elif settings.REGISTRY_LOCATION == 'off-cluster':
995-
secret = self._scheduler.secret.get('deis', 'registry-secret').json()
995+
secret = self._scheduler.secret.get(
996+
settings.WORKFLOW_NAMESPACE, 'registry-secret').json()
996997
username = secret['data']['username']
997998
password = secret['data']['password']
998999
hostname = secret['data']['hostname']
@@ -1105,5 +1106,6 @@ def create_object_store_secret(self):
11051106
try:
11061107
self._scheduler.secret.get(self.id, 'objectstorage-keyfile')
11071108
except KubeException:
1108-
secret = self._scheduler.secret.get('deis', 'objectstorage-keyfile').json()
1109+
secret = self._scheduler.secret.get(
1110+
settings.WORKFLOW_NAMESPACE, 'objectstorage-keyfile').json()
11091111
self._scheduler.secret.create(self.id, 'objectstorage-keyfile', secret['data'])

rootfs/api/settings/production.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,9 @@
241241
# names which apps cannot reserve for routing
242242
DEIS_RESERVED_NAMES = os.environ.get('RESERVED_NAMES', '').replace(' ', '').split(',')
243243

244+
# the k8s namespace in which the controller and workflow were installed.
245+
WORKFLOW_NAMESPACE = os.environ.get('WORKFLOW_NAMESPACE', 'deis')
246+
244247
# default scheduler settings
245248
SCHEDULER_MODULE = 'scheduler'
246249
SCHEDULER_URL = "https://{}:{}".format(

0 commit comments

Comments
 (0)