Merge pull request #634 from helgi/simpler_view_create

ref(views): consolidate all views::create handling into one create function

Author: helgi

rootfs/api/views.py

@@ -152,6 +152,10 @@ class BaseDeisViewSet(viewsets.OwnerViewSet):
     def create(self, request, *args, **kwargs):
         try:
             return super(BaseDeisViewSet, self).create(request, *args, **kwargs)
+        except AlreadyExists as e:
+            return Response({'detail': str(e)}, status=status.HTTP_409_CONFLICT)
+        except EnvironmentError as e:
+            return Response({'detail': str(e)}, status=status.HTTP_400_BAD_REQUEST)
         # If the scheduler oopsie'd
         except KubeException as e:
             return Response({'detail': str(e)}, status=status.HTTP_503_SERVICE_UNAVAILABLE)
@@ -192,14 +196,6 @@ class AppViewSet(BaseDeisViewSet):
     def get_queryset(self, *args, **kwargs):
         return self.model.objects.all(*args, **kwargs)
 
-    def create(self, request, **kwargs):
-        try:
-            return super(AppViewSet, self).create(request, **kwargs)
-        except AlreadyExists as e:
-            return Response({'detail': str(e)}, status=status.HTTP_409_CONFLICT)
-        except EnvironmentError as e:
-            return Response({'detail': str(e)}, status=status.HTTP_400_BAD_REQUEST)
-
     def list(self, request, *args, **kwargs):
         """
         HACK: Instead of filtering by the queryset, we limit the queryset to list only the apps
@@ -292,12 +288,6 @@ class ConfigViewSet(ReleasableViewSet):
     model = models.Config
     serializer_class = serializers.ConfigSerializer
 
-    def create(self, request, **kwargs):
-        try:
-            return super(ConfigViewSet, self).create(request, **kwargs)
-        except EnvironmentError as e:
-            return Response({'detail': str(e)}, status=status.HTTP_400_BAD_REQUEST)
-
     def post_save(self, config):
         release = config.app.release_set.latest()
         self.release = release.new(self.request.user, config=config, build=release.build)