Merge pull request #703 from helgi/get_rc_status

ref(scheduler): use a try / except block instead of get_rc_status, allows for more precise handling

Author: helgi

rootfs/scheduler/__init__.py

@@ -986,22 +986,19 @@ def _create_rc(self, namespace, name, image, command, **kwargs):  # noqa
             error(resp, 'create ReplicationController "{}" in Namespace "{}"', name, namespace)
             logger.debug('template used: {}'.format(json.dumps(template, indent=4)))
 
-        create = False
         for _ in range(30):
-            if not create and self._get_rc_status(namespace, name) == 404:
-                time.sleep(1)
-                continue
-
-            create = True
-            rc = self._get_rc(namespace, name).json()
-            # TODO: Does this matter? Is there a better indicator?
-            if (
-                "observedGeneration" in rc["status"] and
-                rc["metadata"]["generation"] == rc["status"]["observedGeneration"]
-            ):
-                break
+            try:
+                rc = self._get_rc(namespace, name).json()
+                if (
+                    "observedGeneration" in rc["status"] and
+                    rc["metadata"]["generation"] == rc["status"]["observedGeneration"]
+                ):
+                    break
 
-            time.sleep(1)
+                time.sleep(1)
+            except KubeHTTPException as e:
+                if e.response.status_code == 404:
+                    time.sleep(1)
 
         return resp.json()