feat(rootfs/api): add validation and changes.

implement validation for serializer and add termination grace period to
the list changes

Author: notmaxx

rootfs/api/models/release.py

@@ -427,6 +427,7 @@ def save(self, *args, **kwargs):  # noqa
                     changes = 'changed limits for '+', '.join(changes)
                     self.summary += "{} {}".format(self.config.owner, changes)
 
+<<<<<<< HEAD
                 # if the lifecycle_post_start hooks changed, log the dict diff
                 changes = []
                 old_lifecycle_post_start = old_config.lifecycle_post_start if old_config else {}
@@ -459,6 +460,15 @@ def save(self, *args, **kwargs):  # noqa
                 if changes:
                     if self.summary:
                         self.summary += ' and '
+
+                # if the timeouts changed, log the dict diff
+                changes = []
+                old_timeout = old_config.termination_grace_period if old_config else {}
+                diff = dict_diff(self.config.termination_grace_period, old_timeout)
+                if diff.get('added') or diff.get('changed') or diff.get('deleted'):
+                    changes.append('termination_grace_period')
+                if changes:
+                    changes = 'changed timeouts for '+', '.join(changes)
                     self.summary += "{} {}".format(self.config.owner, changes)
 
                 # if the tags changed, log the dict diff

rootfs/api/serializers.py

@@ -301,6 +301,21 @@ def validate_cpu(self, data):
 
         return data
 
+    def validate_termination_grace_period(self, data):
+        for key, value in data.items():
+            if value is None:  # use NoneType to unset an item
+                continue
+
+            if not re.match(PROCTYPE_MATCH, key):
+                raise serializers.ValidationError(PROCTYPE_MISMATCH_MSG)
+
+            timeout = re.match(TERMINATION_GRACE_PERIOD_MATCH, value)
+            if not timeout:
+                raise serializers.ValidationError(
+                    "Termination Grace Period format: <value>, where value must be a numeric")
+
+        return data
+
     def validate_tags(self, data):
         for key, value in data.items():
             if value is None:  # use NoneType to unset an item
@@ -374,22 +389,6 @@ def validate_healthcheck(self, data):
 
         return data
 
-    def validate_termination_grace_period(self, data):
-        for key, value in data.items():
-            if value is None:  # use NoneType to unset an item
-                continue
-
-            if not re.match(PROCTYPE_MATCH, key):
-                raise serializers.ValidationError(PROCTYPE_MISMATCH_MSG)
-
-            timeout = re.match(TERMINATION_GRACE_PERIOD_MATCH, value)
-            if not timeout:
-                raise serializers.ValidationError(
-                    "Termination Grace Period format: <value>, where value must be a numeric")
-
-        return data
-
-
 class ReleaseSerializer(serializers.ModelSerializer):
     """Serialize a :class:`~api.models.Release` model."""