Skip to content

Commit 612797b

Browse files
committed
chore(controller): add app.refresh func annotation
1 parent d3348f1 commit 612797b

4 files changed

Lines changed: 9 additions & 0 deletions

File tree

rootfs/api/models/app.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,10 @@ def _refresh_ingress(self, hosts, tls_map, ssl_redirect, appsettings):
208208
raise ServiceUnavailable('Could not create Ingress in Kubernetes') from e
209209

210210
def refresh(self, app_settings=None, tls=None, domains=None):
211+
"""
212+
Read and write are separated, in transaction the read database is not updated.
213+
When calling, the corresponding resource object needs
214+
"""
211215
if not getattr(self, 'refresh_enabled', True):
212216
return
213217
app_settings = app_settings if app_settings else self.appsettings_set.latest()

rootfs/api/models/appsettings.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -182,5 +182,6 @@ def save(self, *args, **kwargs):
182182
try:
183183
return super(AppSettings, self).save(**kwargs)
184184
finally:
185+
# Read and write are separated, in transaction the read database is not updated
185186
self.app.refresh(app_settings=self)
186187
self.app.log('summary of app setting changes: {}'.format(summary), logging.DEBUG)

rootfs/api/models/domain.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ def save(self, *args, **kwargs):
3636
# Save to DB
3737
return super(Domain, self).save(*args, **kwargs)
3838
finally:
39+
# Read and write are separated, in transaction the read database is not updated
3940
self.app.refresh(domains=domains)
4041

4142
@transaction.atomic
@@ -50,6 +51,7 @@ def delete(self, *args, **kwargs):
5051
# Delete from DB
5152
return super(Domain, self).delete(*args, **kwargs)
5253
finally:
54+
# Read and write are separated, in transaction the read database is not updated
5355
self.app.refresh(domains=domains)
5456

5557
def __str__(self):

rootfs/api/models/tls.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,9 @@ def save(self, *args, **kwargs):
4949
# Save to DB
5050
return super(TLS, self).save(*args, **kwargs)
5151
finally:
52+
# Read and write are separated, in transaction the read database is not updated
5253
self.app.refresh(tls=self)
5354

5455
def sync(self):
56+
# Read and write are separated, in transaction the read database is not updated
5557
self.app.refresh(tls=self)

0 commit comments

Comments
 (0)