Skip to content

Commit 60e500a

Browse files
committed
Merge pull request #608 from helgi/ticket_607
fix(deploy): use the passed in scale of a proc type for deploy
2 parents 6d6ed16 + 8a5eb2a commit 60e500a

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

rootfs/api/models/app.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ def scale(self, user, structure): # noqa
297297
def _scale_pods(self, scale_types):
298298
release = self.release_set.latest()
299299
build_type = app_build_type(release)
300-
for scale_type in scale_types:
300+
for scale_type, replicas in scale_types.items():
301301
image = release.image
302302
version = "v{}".format(release.version)
303303
kwargs = {
@@ -306,7 +306,7 @@ def _scale_pods(self, scale_types):
306306
'tags': release.config.tags,
307307
'envs': release.config.values,
308308
'version': version,
309-
'replicas': scale_types[scale_type],
309+
'replicas': replicas,
310310
'app_type': scale_type,
311311
'build_type': build_type,
312312
'healthcheck': release.config.healthcheck(),
@@ -344,13 +344,14 @@ def deploy(self, user, release):
344344
# deploy application to k8s. Also handles initial scaling
345345
deploys = {}
346346
build_type = app_build_type(release)
347-
for scale_type in self.structure.keys():
347+
for scale_type, replicas in self.structure.items():
348348
deploys[scale_type] = {
349349
'memory': release.config.memory,
350350
'cpu': release.config.cpu,
351351
'tags': release.config.tags,
352352
'envs': release.config.values,
353-
'replicas': 0, # Scaling up happens in a separate operation
353+
# only used if there is no previous RC
354+
'replicas': replicas,
354355
'version': "v{}".format(release.version),
355356
'app_type': scale_type,
356357
'build_type': build_type,

rootfs/scheduler/__init__.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,9 +346,11 @@ def deploy(self, namespace, name, image, command, **kwargs):
346346
new_rc = self._create_rc(namespace, name, image, command, **kwargs)
347347

348348
# Get the desired number to scale to
349-
desired = 1
350349
if old_rc:
351350
desired = int(old_rc["spec"]["replicas"])
351+
else:
352+
desired = kwargs['replicas']
353+
logger.debug('No prior RC could be found for {}-{}'.format(namespace, app_type))
352354

353355
try:
354356
count = 1

0 commit comments

Comments
 (0)