feat(charts): adding external docker_registry support

Author: duanhongyi

charts/controller/templates/controller-deployment.yaml

@@ -24,7 +24,7 @@ spec:
       serviceAccount: drycc-controller
       containers:
         - name: drycc-controller
-          image: quay.io/{{.Values.org}}/controller:{{.Values.docker_tag}}
+          image: {{.Values.docker_registry}}{{.Values.org}}/controller:{{.Values.docker_tag}}
           imagePullPolicy: {{.Values.pull_policy}}
           livenessProbe:
             httpGet:

charts/controller/values.yaml

@@ -1,6 +1,7 @@
 org: "drycc"
 pull_policy: "Always"
-docker_tag: canary
+docker_tag: "canary"
+docker_registry: ""
 app_pull_policy: "Always"
 # A comma-separated list of URLs to send app release information to
 # See https://drycc.com/docs/workflow/managing-workflow/deploy-hooks

rootfs/api/models/app.py

@@ -521,14 +521,15 @@ def deploy(self, release, force_deploy=False, rollback_on_failure=True):  # noqa
         image = settings.SLUGRUNNER_IMAGE if release.build.type == 'buildpack' else release.image
 
         try:
-            # check access to the image, so users can't exploit the k8s image cache
-            # to gain access to other users' images
-            release.check_image_access()
             # create the application config in k8s (secret in this case) for all deploy objects
             self.set_application_config(release)
             # only buildpack apps need access to object storage
+            # only docker apps need check access to the image, so users can't exploit the k8s
+            # image cache to gain access to other users' images
             if release.build.type == 'buildpack':
                 self.create_object_store_secret()
+            else:
+                release.check_image_access()
 
             # gather all proc types to be deployed
             tasks = [