Skip to content

Commit 3f3a228

Browse files
authored
fix(scheduler): pass down the right variable for Deployment revision history limit (#1037)
Prior to this the wrong variable was being passed and as such the revision history feature did not work
1 parent 83df91e commit 3f3a228

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

rootfs/api/models/app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -540,7 +540,7 @@ def deploy(self, release, force_deploy=False):
540540
'routable': routable,
541541
'deploy_batches': batches,
542542
'deploy_timeout': deploy_timeout,
543-
'deployment_history_limit': deployment_history,
543+
'deployment_revision_history_limit': deployment_history,
544544
'release_summary': release.summary,
545545
'pod_termination_grace_period_seconds': pod_termination_grace_period_seconds,
546546
'image_pull_secret_name': image_pull_secret_name,

rootfs/scheduler/resources/deployment.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ def manifest(self, namespace, name, image, entrypoint, command, **kwargs):
9494
}
9595

9696
# Add in how many deployment revisions to keep
97-
if kwargs.get('deployment_revision_history', None) is not None:
98-
manifest['spec']['revisionHistoryLimit'] = int(kwargs.get('deployment_revision_history')) # noqa
97+
if kwargs.get('deployment_revision_history_limit', None) is not None:
98+
manifest['spec']['revisionHistoryLimit'] = int(kwargs.get('deployment_revision_history_limit')) # noqa
9999

100100
# tell pod how to execute the process
101101
kwargs['command'] = entrypoint

0 commit comments

Comments
 (0)