Skip to content

Commit 3cc896f

Browse files
committed
Merge pull request #637 from helgi/ticket_625
fix(models): make dates consistent, output Z instead of UTC for ISO8601 compatibility
2 parents e877a19 + 5322e73 commit 3cc896f

7 files changed

Lines changed: 11 additions & 11 deletions

rootfs/api/tests/test_certificate.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ def test_get_certificate_screens_data(self):
9595

9696
expected = {
9797
'common_name': 'autotest.example.com',
98-
'expires': '2016-03-05T17:14:27UTC',
98+
'expires': '2016-03-05T17:14:27Z',
9999
'fingerprint': '37:24:D8:EB:DC:A4:2C:DA:88:55:C5:19:71:D3:9B:43:BA:AC:3A:CE:33:8E:07:52:1C:51:01:A0:97:43:C9:4D', # noqa
100100
'san': [],
101101
'domains': [],

rootfs/api/tests/test_certificate_use_case_1.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ def test_get_certificate_screens_data(self):
102102
expected = {
103103
'name': self.name,
104104
'common_name': str(self.domain),
105-
'expires': '2017-01-14T23:55:59UTC',
105+
'expires': '2017-01-14T23:55:59Z',
106106
'fingerprint': 'AC:82:58:80:EA:C4:B9:75:C1:1C:52:48:40:28:15:1D:47:AC:ED:88:4B:D4:72:95:B2:C0:A0:DF:4A:A7:60:B6', # noqa
107107
'san': [],
108108
'domains': ['foo.com']

rootfs/api/tests/test_certificate_use_case_2.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def setUp(self):
4141
self.certificates[self.domain]['cert'] = f.read()
4242

4343
# add expires and fingerprints
44-
self.certificates['foo.com']['expires'] = '2017-01-14T23:55:59UTC'
44+
self.certificates['foo.com']['expires'] = '2017-01-14T23:55:59Z'
4545
self.certificates['foo.com']['fingerprint'] = 'AC:82:58:80:EA:C4:B9:75:C1:1C:52:48:40:28:15:1D:47:AC:ED:88:4B:D4:72:95:B2:C0:A0:DF:4A:A7:60:B6' # noqa
4646

4747
def tearDown(self):

rootfs/api/tests/test_certificate_use_case_3.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@ def setUp(self):
4343
self.certificates[domain]['cert'] = f.read()
4444

4545
# add expires and fingerprints
46-
self.certificates['foo.com']['expires'] = '2017-01-14T23:55:59UTC'
46+
self.certificates['foo.com']['expires'] = '2017-01-14T23:55:59Z'
4747
self.certificates['foo.com']['fingerprint'] = 'AC:82:58:80:EA:C4:B9:75:C1:1C:52:48:40:28:15:1D:47:AC:ED:88:4B:D4:72:95:B2:C0:A0:DF:4A:A7:60:B6' # noqa
4848

49-
self.certificates['bar.com']['expires'] = '2017-01-14T23:57:57UTC'
49+
self.certificates['bar.com']['expires'] = '2017-01-14T23:57:57Z'
5050
self.certificates['bar.com']['fingerprint'] = '7A:CA:B8:50:FF:8D:EB:03:3D:AC:AD:13:4F:EE:03:D5:5D:EB:5E:37:51:8C:E0:98:F8:1B:36:2B:20:83:0D:C0' # noqa
5151

5252
def tearDown(self):

rootfs/api/tests/test_certificate_use_case_4.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,15 @@ def setUp(self):
4949
self.certificates[domain]['cert'] = f.read()
5050

5151
# add expires, common_name and fingerprints
52-
self.certificates['*.foo.com']['expires'] = '2017-01-14T23:59:02UTC'
52+
self.certificates['*.foo.com']['expires'] = '2017-01-14T23:59:02Z'
5353
self.certificates['*.foo.com']['fingerprint'] = '35:FA:8F:58:FF:EA:E0:22:79:29:0B:85:58:73:C2:A5:CD:4A:D9:81:D7:10:9D:4D:03:43:41:E4:1D:92:AB:C5' # noqa
5454
self.certificates['*.foo.com']['common_name'] = 'www.foo.com'
5555

56-
self.certificates['foo.com']['expires'] = '2017-01-14T23:55:59UTC'
56+
self.certificates['foo.com']['expires'] = '2017-01-14T23:55:59Z'
5757
self.certificates['foo.com']['fingerprint'] = 'AC:82:58:80:EA:C4:B9:75:C1:1C:52:48:40:28:15:1D:47:AC:ED:88:4B:D4:72:95:B2:C0:A0:DF:4A:A7:60:B6' # noqa
5858
self.certificates['foo.com']['common_name'] = 'foo.com'
5959

60-
self.certificates['bar.com']['expires'] = '2017-01-14T23:57:57UTC'
60+
self.certificates['bar.com']['expires'] = '2017-01-14T23:57:57Z'
6161
self.certificates['bar.com']['fingerprint'] = '7A:CA:B8:50:FF:8D:EB:03:3D:AC:AD:13:4F:EE:03:D5:5D:EB:5E:37:51:8C:E0:98:F8:1B:36:2B:20:83:0D:C0' # noqa
6262
self.certificates['bar.com']['common_name'] = 'bar.com'
6363

rootfs/api/tests/test_certificate_use_case_5.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,12 @@ def setUp(self):
4747
self.certificates[domain]['cert'] = f.read()
4848

4949
# add expires, common_name and fingerprints
50-
self.certificates['*.foo.com']['expires'] = '2017-01-21T21:56:15UTC'
50+
self.certificates['*.foo.com']['expires'] = '2017-01-21T21:56:15Z'
5151
self.certificates['*.foo.com']['fingerprint'] = '8F:8E:5F:F6:7A:78:07:5B:75:3E:10:D5:91:AE:30:4A:48:F4:40:39:90:12:88:B3:41:C6:68:7F:62:F5:CD:EB' # noqa
5252
self.certificates['*.foo.com']['common_name'] = '*.foo.com'
5353
self.certificates['*.foo.com']['san'] = ['foo.com']
5454

55-
self.certificates['bar.com']['expires'] = '2017-01-14T23:57:57UTC'
55+
self.certificates['bar.com']['expires'] = '2017-01-14T23:57:57Z'
5656
self.certificates['bar.com']['fingerprint'] = '7A:CA:B8:50:FF:8D:EB:03:3D:AC:AD:13:4F:EE:03:D5:5D:EB:5E:37:51:8C:E0:98:F8:1B:36:2B:20:83:0D:C0' # noqa
5757
self.certificates['bar.com']['common_name'] = 'bar.com'
5858
self.certificates['bar.com']['san'] = []

rootfs/deis/settings.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@
142142
SECURE_PROXY_SSL_HEADER = ('HTTP_X_FORWARDED_PROTO', 'https')
143143

144144
# standard datetime format used for logging, model timestamps, etc.
145-
DEIS_DATETIME_FORMAT = '%Y-%m-%dT%H:%M:%S%Z'
145+
DEIS_DATETIME_FORMAT = '%Y-%m-%dT%H:%M:%SZ'
146146

147147
REST_FRAMEWORK = {
148148
'DATETIME_FORMAT': DEIS_DATETIME_FORMAT,

0 commit comments

Comments
 (0)