Skip to content

Commit 3a42959

Browse files
author
Matthew Fisher
committed
ref(tests): consolidate HTTP status code checks
1 parent 9e37c8a commit 3a42959

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

rootfs/api/tests/test_app.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -108,21 +108,18 @@ def test_app_actions(self, mock_requests, mock_get):
108108
# test logs - unanticipated status code from deis-logger
109109
mock_response.status_code = 400
110110
response = self.client.get(url)
111-
self.assertEqual(response.status_code, 500)
112-
self.assertContains(response, "Error accessing logs for {}".format(app_id))
111+
self.assertContains(response, "Error accessing logs for {}".format(app_id), status_code=500)
113112

114113
# test logs - success accessing deis-logger
115114
mock_response.status_code = 200
116115
mock_response.content = FAKE_LOG_DATA
117116
response = self.client.get(url)
118-
self.assertEqual(response.status_code, 200)
119-
self.assertContains(response, FAKE_LOG_DATA)
117+
self.assertContains(response, FAKE_LOG_DATA, status_code=200)
120118

121119
# test logs - HTTP request error while accessing deis-logger
122120
mock_get.side_effect = requests.exceptions.RequestException('Boom!')
123121
response = self.client.get(url)
124-
self.assertEqual(response.status_code, 500)
125-
self.assertContains(response, "Error accessing logs for {}".format(app_id))
122+
self.assertContains(response, "Error accessing logs for {}".format(app_id), status_code=500)
126123

127124
# TODO: test run needs an initial build
128125

0 commit comments

Comments
 (0)