fix(controller): Cannot routing:disable

Author: jianxiaoguo

rootfs/api/models/app.py

@@ -209,10 +209,10 @@ def _refresh_ingress(self, hosts, tls_map, ssl_redirect):
         except KubeException as e:
             raise ServiceUnavailable('Could not create Ingress in Kubernetes') from e
 
-    def refresh(self):
+    def refresh(self, app_settings=None):
         if not getattr(self, 'refresh_enabled', True):
             return
-        app_settings = self.appsettings_set.latest()
+        app_settings = app_settings if not app_settings else self.appsettings_set.latest()
         if not app_settings.routable:
             return
         tls = self.tls_set.latest()

rootfs/api/models/appsettings.py

@@ -52,7 +52,7 @@ def _update_routable(self, previous_settings):
         old = getattr(previous_settings, 'routable', None)
         new = getattr(self, 'routable', None)
         # If no previous settings then assume it is the first record and default to true
-        if not previous_settings:
+        if previous_settings is None:
             setattr(self, 'routable', True)
             self.app.routable(True)
         # if nothing changed copy the settings from previous
@@ -182,5 +182,5 @@ def save(self, *args, **kwargs):
         try:
             return super(AppSettings, self).save(**kwargs)
         finally:
-            self.app.refresh()
+            self.app.refresh(app_settings=self)
         self.app.log('summary of app setting changes: {}'.format(summary), logging.DEBUG)