fix(pipeline): exception msg is None

Author: duanhongyi

rootfs/api/models/app.py

@@ -316,11 +316,11 @@ def pipeline(self, release, ptypes, force_deploy=False):
             ptypes = list(ptypes) if ptypes is not None else ptypes
             release.add_condition(state="succeed", action="pipeline", ptypes=ptypes)
         except Exception as e:
-            release.failed, release.state = True, "crashed"
+            release.failed, release.state, msg = True, "crashed", f"{type(e).__name__}: {e}"
             ptypes = list(ptypes) if ptypes is not None else ptypes
             release.add_condition(
-                state="crashed", action="pipeline", ptypes=ptypes, exception=str(e))
-            self.log(f"{prefix} pipeline runtime error: {release.exception}", logging.ERROR)
+                state="crashed", action="pipeline", ptypes=ptypes, exception=msg)
+            self.log(f"{prefix} pipeline runtime error, {msg}", logging.ERROR)
         finally:
             DeployLock(self.pk).release(ptypes)  # release all locks
             release.save(update_fields=["state", "failed"])  # avoid overwriting other fields

rootfs/api/tests/test_config.py

@@ -412,7 +412,7 @@ def test_config_deploy_failure(self, mock_requests):
             app = App.objects.get(id=app_id)
             release = app.release_set.latest()
             self.assertEqual(release.failed, True)
-            self.assertEqual(release.conditions[0]['exception'], "Boom!")
+            self.assertEqual(release.conditions[0]['exception'], "Exception: Boom!")
 
     def test_invalid_config_keys(self, mock_requests):
         """Test that invalid config keys are rejected.
@@ -524,7 +524,8 @@ def test_config_failures(self, mock_requests):
             self.assertEqual(response.status_code, 201)
             self.assertEqual(app.release_set.latest().version, 4)
             self.assertEqual(app.release_set.latest().failed, True)
-            self.assertEqual(app.release_set.latest().conditions[0]['exception'], "Boom!")
+            self.assertEqual(
+                app.release_set.latest().conditions[0]['exception'], "Exception: Boom!")
             self.assertEqual(app.release_set.filter(failed=False).latest().version, 3)
 
         # create a build to see that the new release is created with the last successful config

rootfs/api/tests/test_release.py

@@ -132,7 +132,8 @@ def test_conditions(self, mock_requests):
             self.assertEqual(response.status_code, 201, response.data)
             url = f'/v2/apps/{app_id}/releases/'
             response = self.client.get(url)
-            self.assertEqual(response.data['results'][0]['conditions'][0]['exception'], 'Boom!')
+            self.assertEqual(
+                response.data['results'][0]['conditions'][0]['exception'], 'Exception: Boom!')
 
     def test_get_image(self, mock_requests):
         app_id = self.create_app()