Skip to content

Commit 105c514

Browse files
authored
ref(scheduler): remove yaml lib dependency (#959)
1 parent 77dbf94 commit 105c514

2 files changed

Lines changed: 26 additions & 28 deletions

File tree

rootfs/requirements.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ ndg-httpsclient==0.4.2
1313
psycopg2==2.6.2
1414
pyOpenSSL==16.0.0
1515
pytz==2016.6.1
16-
ruamel.yaml==0.11.14
1716
requests==2.10.0
1817
requests-toolbelt==0.7.0
1918
simpleflock==0.0.3

rootfs/scheduler/__init__.py

Lines changed: 26 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,13 @@
44
import logging
55
import operator
66
import os
7-
import string
87
import time
98
from urllib.parse import urljoin
109
import base64
1110

1211
from django.conf import settings
1312
from docker.auth import auth as docker_auth
1413
from .states import PodState
15-
import ruamel.yaml
1614
import requests
1715
from requests_toolbelt import user_agent
1816
from .utils import dict_merge
@@ -22,27 +20,6 @@
2220

2321
logger = logging.getLogger(__name__)
2422

25-
# Ports and app type will be overwritten as required
26-
SERVICE_TEMPLATE = """\
27-
kind: Service
28-
apiVersion: v1
29-
metadata:
30-
name: $name
31-
labels:
32-
app: $name
33-
heritage: deis
34-
annotations: {}
35-
spec:
36-
ports:
37-
- name: http
38-
port: 80
39-
targetPort: 5000
40-
protocol: TCP
41-
selector:
42-
app: $name
43-
heritage: deis
44-
"""
45-
4623

4724
class KubeException(Exception):
4825
def __init__(self, *args, **kwargs):
@@ -1054,7 +1031,7 @@ def create_rc(self, namespace, name, image, entrypoint, command, **kwargs):
10541031
resp,
10551032
'create ReplicationController "{}" in Namespace "{}"', name, namespace
10561033
)
1057-
self.log(namespace, 'manifest used: {}'.format(ruamel.yaml.dump(manifest)), logging.DEBUG) # noqa
1034+
self.log(namespace, 'manifest used: {}'.format(json.dumps(manifest, indent=4)), logging.DEBUG) # noqa
10581035

10591036
self._wait_until_rc_is_updated(namespace, name)
10601037

@@ -1292,10 +1269,32 @@ def get_services(self, namespace, **kwargs):
12921269
return response
12931270

12941271
def create_service(self, namespace, name, data={}, **kwargs):
1295-
l = {"name": namespace}
1272+
# Ports and app type will be overwritten as required
1273+
manifest = {
1274+
'kind': 'Service',
1275+
'apiVersion': 'v1',
1276+
'metadata': {
1277+
'name': namespace,
1278+
'labels': {
1279+
'app': namespace,
1280+
'heritage': 'deis'
1281+
},
1282+
'annotations': {}
1283+
},
1284+
'spec': {
1285+
'ports': [{
1286+
'name': 'http',
1287+
'port': 80,
1288+
'targetPort': 5000,
1289+
'protocol': 'TCP'
1290+
}],
1291+
'selector': {
1292+
'app': namespace,
1293+
'heritage': 'deis'
1294+
}
1295+
}
1296+
}
12961297

1297-
# Merge external data on to the prefined manifest
1298-
manifest = ruamel.yaml.load(string.Template(SERVICE_TEMPLATE).substitute(l))
12991298
data = dict_merge(manifest, data)
13001299
url = self._api("/namespaces/{}/services", namespace)
13011300
response = self.session.post(url, json=data)

0 commit comments

Comments
 (0)