Skip to content

Commit 050185d

Browse files
committed
chore(controller): using the api_version instead of hard coding
1 parent 5037bbf commit 050185d

10 files changed

Lines changed: 14 additions & 17 deletions

File tree

rootfs/scheduler/resources/events.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def create(self, namespace, name, message, **kwargs):
1717
url = self.api('/namespaces/{}/events'.format(namespace))
1818
data = {
1919
'kind': 'Event',
20-
'apiVersion': 'v1',
20+
'apiVersion': self.api_version,
2121
'count': kwargs.get('count', 1),
2222
'metadata': {
2323
'creationTimestamp': datetime.now().strftime(DATETIME_FORMAT),

rootfs/scheduler/resources/limits.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def create(self, namespace_name, name, **kwargs):
2424
"""
2525
url = self.api("/namespaces/{}/limitranges".format(namespace_name))
2626
manifest = {
27-
"apiVersion": "v1",
27+
"apiVersion": self.api_version,
2828
"kind": "LimitRange",
2929
"metadata": {
3030
"namespace": namespace_name,

rootfs/scheduler/resources/namespace.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def create(self, namespace):
3030
url = self.api("/namespaces")
3131
data = {
3232
"kind": "Namespace",
33-
"apiVersion": "v1",
33+
"apiVersion": self.api_version,
3434
"metadata": {
3535
"name": namespace,
3636
"labels": {

rootfs/scheduler/resources/pod.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ def manifest(self, namespace, name, image, **kwargs):
142142
# create base pod structure
143143
manifest = {
144144
'kind': 'Pod',
145-
'apiVersion': 'v1',
145+
'apiVersion': self.api_version,
146146
'metadata': {
147147
'name': name,
148148
'namespace': namespace,

rootfs/scheduler/resources/pvc.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,12 @@
66
class PersistentVolumeClaim(Resource):
77
short_name = 'pvc'
88

9-
@staticmethod
10-
def manifest(namespace, name, version=None, **kwargs):
9+
def manifest(self, namespace, name, version=None, **kwargs):
1110
labels = {
1211
'heritage': 'drycc',
1312
}
1413
data = {
15-
"apiVersion": "v1",
14+
"apiVersion": self.api_version,
1615
"kind": "PersistentVolumeClaim",
1716
"metadata": {
1817
"name": name,

rootfs/scheduler/resources/quota.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def create(self, namespace_name, name, **kwargs):
2525
url = self.api("/namespaces/{}/resourcequotas".format(namespace_name))
2626
manifest = {
2727
"kind": "ResourceQuota",
28-
"apiVersion": "v1",
28+
"apiVersion": self.api_version,
2929
"metadata": {
3030
"namespace": namespace_name,
3131
"name": name,

rootfs/scheduler/resources/rc.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def get(self, namespace, name=None, **kwargs):
3131
def create(self, namespace, name, image, entrypoint, command, **kwargs):
3232
manifest = {
3333
'kind': 'ReplicationController',
34-
'apiVersion': 'v1',
34+
'apiVersion': self.api_version,
3535
'metadata': {
3636
'name': name,
3737
'labels': {

rootfs/scheduler/resources/secret.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def manifest(self, namespace, name, data, secret_type='Opaque', labels={}):
5151

5252
manifest = {
5353
'kind': 'Secret',
54-
'apiVersion': 'v1',
54+
'apiVersion': self.api_version,
5555
'metadata': {
5656
'name': name,
5757
'namespace': namespace,

rootfs/scheduler/resources/service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def create(self, namespace, name, **kwargs):
3131
# Ports and app type will be overwritten as required
3232
manifest = {
3333
'kind': 'Service',
34-
'apiVersion': 'v1',
34+
'apiVersion': self.api_version,
3535
'metadata': {
3636
'name': name,
3737
'labels': {

rootfs/scheduler/resources/svcat.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,12 @@ class ServiceCatalog(Resource):
77
api_prefix = 'apis'
88
short_name = 'svcat'
99

10-
@staticmethod
11-
def service_instance_manifest(namespace, name, version=None, **kwargs):
10+
def service_instance_manifest(self, namespace, name, version=None, **kwargs):
1211
labels = {
1312
'heritage': 'drycc',
1413
}
1514
data = {
16-
"apiVersion": 'servicecatalog.k8s.io/v1beta1',
15+
"apiVersion": self.api_version,
1716
"kind": "ServiceInstance",
1817
"metadata": {
1918
"name": name,
@@ -110,13 +109,12 @@ def delete_instance(self, namespace, name):
110109
raise KubeHTTPException(response, 'delete serviceinstance ' + name)
111110
return response
112111

113-
@staticmethod
114-
def service_binding_manifest(namespace, name, version=None, **kwargs):
112+
def service_binding_manifest(self, namespace, name, version=None, **kwargs):
115113
labels = {
116114
'heritage': 'drycc',
117115
}
118116
data = {
119-
"apiVersion": 'servicecatalog.k8s.io/v1beta1',
117+
"apiVersion": self.api_version,
120118
"kind": "ServiceBinding",
121119
"metadata": {
122120
"name": name,

0 commit comments

Comments
 (0)