chore(controller): optimize app refresh timing

Author: duanhongyi

rootfs/api/models/appsettings.py

@@ -177,11 +177,8 @@ def save(self, *args, **kwargs):
         if not self.summary and previous_settings:
             self.delete()
             raise AlreadyExists("{} changed nothing".format(self.owner))
-
         summary = ' '.join(self.summary)
-        try:
-            return super(AppSettings, self).save(**kwargs)
-        finally:
-            # Read and write are separated, in transaction the read database is not updated
-            self.app.refresh(app_settings=self)
         self.app.log('summary of app setting changes: {}'.format(summary), logging.DEBUG)
+        super(AppSettings, self).save(**kwargs)
+        # Read and write are separated, in transaction the read database is not updated
+        self.app.refresh(app_settings=self)

rootfs/api/models/domain.py

@@ -27,32 +27,25 @@ class Meta:
 
     @transaction.atomic
     def save(self, *args, **kwargs):
+        super(Domain, self).save(*args, **kwargs)
+        # Read and write are separated, in transaction the read database is not updated
         domains = list(self.app.domain_set.all())
-        # certificate attach update domains
         if self in domains:
             domains.remove(self)
         domains.append(self)
-        try:
-            # Save to DB
-            return super(Domain, self).save(*args, **kwargs)
-        finally:
-            # Read and write are separated, in transaction the read database is not updated
-            self.app.refresh(domains=domains)
+        self.app.refresh(domains=domains)
 
     @transaction.atomic
     def delete(self, *args, **kwargs):
         # Deatch cert, updates k8s
         if self.certificate:
             self.certificate.detach(domain=str(self.domain))
+        super(Domain, self).delete(*args, **kwargs)
+        # Read and write are separated, in transaction the read database is not updated
         domains = list(self.app.domain_set.all())
         if self in domains:
             domains.remove(self)
-        try:
-            # Delete from DB
-            return super(Domain, self).delete(*args, **kwargs)
-        finally:
-            # Read and write are separated, in transaction the read database is not updated
-            self.app.refresh(domains=domains)
+        self.app.refresh(domains=domains)
 
     def __str__(self):
         return self.domain

rootfs/api/models/tls.py

@@ -45,12 +45,8 @@ def _check_previous_tls_settings(self):
     @transaction.atomic
     def save(self, *args, **kwargs):
         self._check_previous_tls_settings()
-        try:
-            # Save to DB
-            return super(TLS, self).save(*args, **kwargs)
-        finally:
-            # Read and write are separated, in transaction the read database is not updated
-            self.app.refresh(tls=self)
+        super(TLS, self).save(*args, **kwargs)
+        self.sync()
 
     def sync(self):
         # Read and write are separated, in transaction the read database is not updated